Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toward removing robotlocomotion/director tap #19295

Closed
1 of 2 tasks
svenevs opened this issue Apr 27, 2023 · 3 comments
Closed
1 of 2 tasks

Toward removing robotlocomotion/director tap #19295

svenevs opened this issue Apr 27, 2023 · 3 comments
Assignees
Labels
component: distribution Nightly binaries, monthly releases, docker, installation priority: low type: feature request

Comments

@svenevs
Copy link
Contributor

svenevs commented Apr 27, 2023

VTK and clang-format are the only things that come from https://github.com/RobotLocomotion/homebrew-director

$ grep -ri robot setup/mac/
setup/mac/binary_distribution/Brewfile:4:tap 'robotlocomotion/director'
setup/mac/binary_distribution/Brewfile:27:brew 'robotlocomotion/director/[email protected]'
setup/mac/source_distribution/Brewfile:4:tap 'robotlocomotion/director'
setup/mac/source_distribution/Brewfile:7:brew 'robotlocomotion/director/clang-format@12'

When building locally using brew install -v --build-from-source ./[email protected], downloading and staging take a bit, and there are (at least with clang 12) 795 objects being compiled. AFAICT this gets compiled in serial

  • mac mini arm64: ~2 minutes 12 seconds.
  • older x86 mac: ~6 minutes 6 seconds.

Seems possibly reasonable to incorporate this into drake's workspace if we so desired. Then again, this is notably a lot more time than just downloading our precompiled bottle. There aren't many dependencies for the formula, and as a result we rarely need to rebottle it (haven't needed to since we switched to 12 and did the first one).

CC @BetsyMcPhail @jwnimmer-tri

@svenevs svenevs added priority: low component: build system Bazel, CMake, dependencies, memory checkers, linters labels Apr 27, 2023
@svenevs svenevs self-assigned this Apr 27, 2023
@jwnimmer-tri jwnimmer-tri added component: distribution Nightly binaries, monthly releases, docker, installation and removed component: build system Bazel, CMake, dependencies, memory checkers, linters labels Apr 27, 2023
@jwnimmer-tri
Copy link
Collaborator

LLVM does have BUILD files now. I have a WIP here where I started trying it. I don't remember what (if any) roadblocks I hit.

@jwnimmer-tri
Copy link
Collaborator

Also another WIP here is relevant. Both should probably happen together.

@jwnimmer-tri
Copy link
Collaborator

Fixed in #21339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: distribution Nightly binaries, monthly releases, docker, installation priority: low type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants