Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: Async peers instead of changing config type #1321

Merged
merged 11 commits into from
Nov 20, 2023
Merged

Conversation

RobinTail
Copy link
Owner

There is a thing that I don't like in #1301 — the direction where config goes.
In my initial concept, I wanted to achieve the simplicity of config, being object of primitive properties.
Here I'd like to explore another direction by restoring back compression and upload as bool | Options, but instead — trying to import the corresponding peers dynamically.
For that, however, createServer has to become async, which is also breaking, but I believe, might be much less breaking, and the outcome of that should be nicer.

@RobinTail RobinTail added refactoring The better way to achieve the same result breaking Backward incompatible changes labels Nov 20, 2023
@RobinTail RobinTail added this to the v15 milestone Nov 20, 2023
@RobinTail RobinTail marked this pull request as ready for review November 20, 2023 22:39
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.
And it seems to be working good.
I like it this way, so the config will remain simpler.

@RobinTail
Copy link
Owner Author

Restored documentation and adjusted the changelog.
LGTM

@RobinTail RobinTail added documentation Improvements or additions to documentation prevention labels Nov 20, 2023
@RobinTail RobinTail changed the title Experiment: Async peers Ref: Async peers instead of changing config type Nov 20, 2023
@RobinTail RobinTail merged commit 0a8c567 into prepare-v15 Nov 20, 2023
@RobinTail RobinTail deleted the async-peers branch November 20, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Backward incompatible changes documentation Improvements or additions to documentation prevention refactoring The better way to achieve the same result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant