`v15` is for Vika #1301

RobinTail · 2023-11-10T12:32:42Z

The dedication

Vika was 24 years young transgender woman when her boyfriend (a policeman, by the way) murdered her. Moreover, in order to confuse the tracks and create the impression that the murdered woman was alive, the policeman cut off her finger, unlocked her mobile phone and sent messages to her friends. On the evening of October 13, 2020, he was detained, confessed and showed where he buried the girl’s body.

https://ngs.ru/text/criminal/2022/09/29/71695301/

Transgender women suffer too frequently from transphobic violence and cruelty, being the less protected social group. I'd like to raise an awareness of this problem. Humans should be creators — not killers. Protect transgender women.

Find out more about Vika's story from her interview: https://ngs.ru/text/relations/2019/06/25/66137377/

Version 15

Key features: supporting any compatible logger and any compatible testing framework, using module augmentation approach. Both jest and vitest are supported automatically. winston is optional. Dynamic loading for optional peer dependencies.
Means: createServer and attachRouting methods become asynchronous.

compressor and uploader config, optional peers #1255
Supporting both jest and vitest for testEndpoint() method #1280
Feat: Supporting any logger #1314
Augmentation of mocking function type #1335
- supporting any testing framework having function mocking method
Fix: supporting primitive values for logging metadata #1343
Ref: common starter for all servers #1342
Restoring createLogger in v15 #1347

- Making `compression` and `express-fileupload` to be optional peer dependencies. - Changing `upload` to `uploader` and `compression` to `compressor` in config.

According to discussion #1232

…thout logger entries.

There is a thing that I don't like in #1301 — the direction where config goes. In my initial concept, I wanted to achieve the simplicity of config, being object of primitive properties. Here I'd like to explore another direction by restoring back `compression` and `upload` as `bool | Options`, but instead — trying to import the corresponding peers dynamically. For that, however, `createServer` has to become `async`, which is also breaking, but I believe, might be much less breaking, and the outcome of that should be nicer.

src/server.ts

src/logger.ts

RobinTail

reviewed the whole PR

``` logger.info("Listening", 8090) ``` will work in v15

In v15 `createServer` becomes async (returns Promise). ~~I'd like to use that advantage to await for actual listening started before fulfilling the Promise.~~ After some considerations I decided to postpone that feature and limit the PR only to refactoring with a common starter.

RobinTail

ok. time for another beta

RobinTail · 2023-12-01T21:00:06Z

✅ beta5 QA passed

Cherry-picking 034d31c originally made in #1343 for #1301

I decided to restore `createLogger` exposition sync, but with `winston` argument. Thus, all async `loadPeer` are concentrated in `server.ts` file and there are less breaking changes.

RobinTail

nice

RobinTail · 2023-12-01T23:03:25Z

✅ beta6 QA passed.
I'm pretty happy with it now.

RobinTail · 2023-12-02T10:31:13Z

During the final review I found an issue and fixed it in v14 #1348

RobinTail · 2023-12-02T10:41:46Z

✅ beta7 QA passed.
I hope it's ready now

…orted along with winston.

RobinTail

ready 🐎

Working on compatibility support of vitest in #1301 I was surprised by how good it works outta the box. Meanwhile, I'm not satisfied by the ESM support in jest, which is probably not going to be better [in Jest 30](https://github.com/jestjs/jest/milestone/15). So I'm exploring the possibility to switch to vitest instead. Compatibility with jest will remain. Also - I don't like jest globals - I don't like that jest changes the behaviour of `node:assert` (asserting with message:CustomError) against its documentation.

v15: Adjusting workflows.

ab6bdea

RobinTail added the CI/CD label Nov 10, 2023

RobinTail added this to the v15 milestone Nov 10, 2023

compressor and uploader config, optional peers (#1255)

545f366

- Making `compression` and `express-fileupload` to be optional peer dependencies. - Changing `upload` to `uploader` and `compression` to `compressor` in config.

RobinTail added dependencies Pull requests that update a dependency file refactoring The better way to achieve the same result breaking Backward incompatible changes labels Nov 10, 2023

Supporting both jest and vitest for testEndpoint() method (#1280)

198c94a

According to discussion #1232

RobinTail added the coverage Additional tests label Nov 10, 2023

RobinTail added 7 commits November 10, 2023 23:38

Moving jsdoc comment and removing todo in EndpointsFactory.

f00a9a3

Merge branch 'master' into prepare-v15

c76f4e4

Merge branch 'master' into prepare-v15

b3b2547

Merge branch 'master' into prepare-v15

504424c

Removing lock file from vitest test.

8259934

Integration and ESM tests: using latest compatible versions each time.

e57d3e9

Security: listing the upcoming version, adjusting the link.

a60f3f0

RobinTail changed the title ~~Next: v15~~ v15 is for Vika Nov 16, 2023

Dedication.

648d11e

RobinTail added the dedication label Nov 16, 2023

RobinTail and others added 8 commits November 18, 2023 18:59

Merge branch 'master' into prepare-v15

2358649

Changelog: cherry-picking the anounce from abstract-logger branch, wi…

dbc4fcf

…thout logger entries.

Merge branch 'master' into prepare-v15

ff6c1f1

Merge branch 'master' into prepare-v15

bcadc97

Merge branch 'master' into prepare-v15

154f1df

Merge branch 'master' into prepare-v15

26c6bfc

Update SECURITY.md

0421629

Merge branch 'master' into prepare-v15

5eb7b99

RobinTail mentioned this pull request Nov 20, 2023

Ref: Async peers instead of changing config type #1321

Merged

RobinTail added 2 commits November 20, 2023 23:46

Fix: ensure type import only in upload schema.

e0c34c9

Security: organizing package to make reference stable.

93a0d49

RobinTail commented Nov 30, 2023

View reviewed changes

src/server.ts Outdated Show resolved Hide resolved

RobinTail commented Nov 30, 2023

View reviewed changes

src/logger.ts Outdated Show resolved Hide resolved

RobinTail added 2 commits November 30, 2023 22:03

SimplifiedWinstonConfig: making color optional feature.

1796922

Additional tests for isSimplifiedWinstonConfig().

6c8c9ed

RobinTail commented Nov 30, 2023

View reviewed changes

RobinTail added 2 commits December 1, 2023 20:57

Fix: supporting primitive values for logging metadata (#1343)

034d31c

``` logger.info("Listening", 8090) ``` will work in v15

RobinTail commented Dec 1, 2023

View reviewed changes

15.0.0-beta5

b3fa16b

RobinTail mentioned this pull request Dec 1, 2023

Supporting primitive values for logging metadata, port for v14 #1346

Merged

RobinTail added a commit that referenced this pull request Dec 1, 2023

Supporting primitive values for logging metadata, port for v14 (#1346)

05c1ea1

Cherry-picking 034d31c originally made in #1343 for #1301

RobinTail added 2 commits December 1, 2023 23:13

Merge branch 'master' into prepare-v15

0422d30

Restoring createLogger in v15 (#1347)

cb568d8

I decided to restore `createLogger` exposition sync, but with `winston` argument. Thus, all async `loadPeer` are concentrated in `server.ts` file and there are less breaking changes.

RobinTail commented Dec 1, 2023

View reviewed changes

15.0.0-beta6

1280957

RobinTail added 2 commits December 2, 2023 10:42

CI: removing this branch from triggers

e8c8b14

Peer fix: allowing vitest >=0.34.6 <2.

ff6b9d0

RobinTail added 2 commits December 2, 2023 11:32

Merge branch 'master' into prepare-v15

90551f4

15.0.0-beta7

50debed

Changelog: minor, mentioning again that any compatible logger is supp…

a5488ac

…orted along with winston.

RobinTail commented Dec 2, 2023

View reviewed changes

RobinTail merged commit 7c0e0ed into master Dec 2, 2023

RobinTail deleted the prepare-v15 branch December 2, 2023 10:53

RobinTail mentioned this pull request Dec 10, 2023

Switching to vitest #1369

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`v15` is for Vika #1301

`v15` is for Vika #1301

RobinTail commented Nov 10, 2023 •

edited

Loading

RobinTail left a comment

RobinTail left a comment

RobinTail commented Dec 1, 2023

RobinTail left a comment

RobinTail commented Dec 1, 2023

RobinTail commented Dec 2, 2023

RobinTail commented Dec 2, 2023

RobinTail left a comment

v15 is for Vika #1301

v15 is for Vika #1301

Conversation

RobinTail commented Nov 10, 2023 • edited Loading

The dedication

Version 15

RobinTail left a comment

Choose a reason for hiding this comment

RobinTail left a comment

Choose a reason for hiding this comment

RobinTail commented Dec 1, 2023

RobinTail left a comment

Choose a reason for hiding this comment

RobinTail commented Dec 1, 2023

RobinTail commented Dec 2, 2023

RobinTail commented Dec 2, 2023

RobinTail left a comment

Choose a reason for hiding this comment

`v15` is for Vika #1301

`v15` is for Vika #1301

RobinTail commented Nov 10, 2023 •

edited

Loading