Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import after PR merge conflict #1997

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

tonidero
Copy link
Contributor

Description

Fix issue after merging recent Paywalls PR that was making it fail to compile. Tests passed on the respective branches but we didn't have tests against latest main before merging the latest.

@tonidero tonidero marked this pull request as ready for review December 19, 2024 12:38
@tonidero tonidero enabled auto-merge (squash) December 19, 2024 12:38
@tonidero
Copy link
Contributor Author

Emerge size tests failed because build failed on main, so it can't compare it. Merging anyway.

@tonidero tonidero merged commit fe5ac73 into main Dec 19, 2024
8 of 9 checks passed
@tonidero tonidero deleted the fix-paywalls-v2-conflict branch December 19, 2024 13:03
tonidero pushed a commit that referenced this pull request Jan 2, 2025
**This is an automatic release.**

## RevenueCat SDK
### 🐞 Bugfixes
* improvements for fr translations (#2019) via Andy Boedo (@aboedo)

### 🔄 Other Changes
* Feedback Surveys (#2010) via Cesar de la Vega (@vegaro)
* [Paywalls V2] Fixes previews (#2015) via JayShortway (@JayShortway)
* [Paywalls V2] Moves validation logic to the Loading phase (#2007) via
JayShortway (@JayShortway)
* Add Cancel subscriptions support (#2008) via Cesar de la Vega
(@vegaro)
* [Paywalls V2] Localizations are kept in a NonEmptyMap (#2001) via
JayShortway (@JayShortway)
* [Paywalls V2] `TextComponentState` handles locale changes (#2000) via
JayShortway (@JayShortway)
* [Paywalls V2] Some minor cleanup (#1994) via JayShortway
(@JayShortway)
* [Paywalls V2] `StackComponentView` handles overrides with
`StackComponentState` (#1993) via JayShortway (@JayShortway)
* Customer Center restores [CC-2] (#1999) via Cesar de la Vega (@vegaro)
* [Paywalls V2] Add more image component previews to test parent being
smaller than image size (#2004) via Toni Rico (@tonidero)
* [Paywalls V2] Add `PurchaseButtonComponent` support (#2002) via Toni
Rico (@tonidero)
* Build Customer Center from JSON (#1998) via Cesar de la Vega (@vegaro)
* Fix missing import after PR merge conflict (#1997) via Toni Rico
(@tonidero)
* [Paywalls V2] Add `StickyFooterComponentView` (#1991) via Toni Rico
(@tonidero)
* [Paywalls V2] `TextComponentView` handles overrides with
`TextComponentState` (#1989) via JayShortway (@JayShortway)

Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants