[Paywalls V2] StackComponentView handles overrides with StackComponentState
#1993
Conversation
…s it to assertRectangularBorderColor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
=======================================
Coverage 81.95% 81.95%
=======================================
Files 260 260
Lines 8507 8507
Branches 1226 1226
=======================================
Hits 6972 6972
Misses 1036 1036
Partials 499 499 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| @get:JvmSynthetic | ||
| val visible by derivedStateOf { presentedPartial?.partial?.visible ?: true } |
There was a problem hiding this comment.
Should this default to the style visibility? I don't know if this is something controllable from the dashboard but seems like a better default IMO?
| val visible by derivedStateOf { presentedPartial?.partial?.visible ?: true } | |
| val visible by derivedStateOf { presentedPartial?.partial?.visible ?: style.visible } |
There was a problem hiding this comment.
Oh good that you mention it! This made me realize that *ComponentStyles don't need a visible property anymore. I removed them from StackComponentStyle and TextComponentStyle here: bf27e45. Will need to do the same once ImageComponentStyle gets an accompanying ImageComponentState.
The reason for this is that a component is always visible, except when a PresentedPartial override tells it it's not. This is to support scenarios where a developer wants to hide a component for a certain window size, for instance. That's why only the PresentedPartial overrides have a visible property, and when that's not set the component is visible.
There was a problem hiding this comment.
👍 makes sense! Yeah I didn't think it made much sense to control the visibility from the dashboard like that. This makes more sense!
# Conflicts: # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewWindowTests.kt
# Conflicts: # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewTests.kt # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewTests.kt # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewWindowTests.kt
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * improvements for fr translations (#2019) via Andy Boedo (@aboedo) ### 🔄 Other Changes * Feedback Surveys (#2010) via Cesar de la Vega (@vegaro) * [Paywalls V2] Fixes previews (#2015) via JayShortway (@JayShortway) * [Paywalls V2] Moves validation logic to the Loading phase (#2007) via JayShortway (@JayShortway) * Add Cancel subscriptions support (#2008) via Cesar de la Vega (@vegaro) * [Paywalls V2] Localizations are kept in a NonEmptyMap (#2001) via JayShortway (@JayShortway) * [Paywalls V2] `TextComponentState` handles locale changes (#2000) via JayShortway (@JayShortway) * [Paywalls V2] Some minor cleanup (#1994) via JayShortway (@JayShortway) * [Paywalls V2] `StackComponentView` handles overrides with `StackComponentState` (#1993) via JayShortway (@JayShortway) * Customer Center restores [CC-2] (#1999) via Cesar de la Vega (@vegaro) * [Paywalls V2] Add more image component previews to test parent being smaller than image size (#2004) via Toni Rico (@tonidero) * [Paywalls V2] Add `PurchaseButtonComponent` support (#2002) via Toni Rico (@tonidero) * Build Customer Center from JSON (#1998) via Cesar de la Vega (@vegaro) * Fix missing import after PR merge conflict (#1997) via Toni Rico (@tonidero) * [Paywalls V2] Add `StickyFooterComponentView` (#1991) via Toni Rico (@tonidero) * [Paywalls V2] `TextComponentView` handles overrides with `TextComponentState` (#1989) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <[email protected]>
Description
This PR is analogous to #1989, and the motivation behind it is the same.
StackComponentState.StackComponentViewusesStackComponentState.StyleFactoryis simplified further.StackComponentViewWindowTests.StackComponentViewTests.