Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics: Remove unused anonymizer #1795

Merged
merged 3 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ open class PurchasesConfiguration(builder: Builder) {
/**
* Enabling diagnostics will send some performance and debugging information from the SDK to our servers.
* Examples of this information include response times, cache hits or error codes.
* This information will be anonymized so it can't be traced back to the end-user.
* No personal identifiable information will be collected.
* The default value is false.
*
* Diagnostics is only available in Android API 24+
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import android.content.Context
import android.content.pm.PackageManager
import android.preference.PreferenceManager
import androidx.annotation.VisibleForTesting
import com.revenuecat.purchases.common.Anonymizer
import com.revenuecat.purchases.common.AppConfig
import com.revenuecat.purchases.common.Backend
import com.revenuecat.purchases.common.BackendHelper
Expand All @@ -18,7 +17,6 @@ import com.revenuecat.purchases.common.LogIntent
import com.revenuecat.purchases.common.PlatformInfo
import com.revenuecat.purchases.common.caching.DeviceCache
import com.revenuecat.purchases.common.debugLog
import com.revenuecat.purchases.common.diagnostics.DiagnosticsAnonymizer
import com.revenuecat.purchases.common.diagnostics.DiagnosticsFileHelper
import com.revenuecat.purchases.common.diagnostics.DiagnosticsHelper
import com.revenuecat.purchases.common.diagnostics.DiagnosticsSynchronizer
Expand Down Expand Up @@ -105,7 +103,6 @@ internal class PurchasesFactory(
diagnosticsTracker = DiagnosticsTracker(
appConfig,
diagnosticsFileHelper,
DiagnosticsAnonymizer(Anonymizer()),
diagnosticsHelper,
eventsDispatcher,
)
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import kotlin.time.Duration
internal class DiagnosticsTracker(
private val appConfig: AppConfig,
private val diagnosticsFileHelper: DiagnosticsFileHelper,
private val diagnosticsAnonymizer: DiagnosticsAnonymizer,
private val diagnosticsHelper: DiagnosticsHelper,
private val diagnosticsDispatcher: Dispatcher,
) {
Expand Down Expand Up @@ -260,10 +259,9 @@ internal class DiagnosticsTracker(

internal fun trackEventInCurrentThread(diagnosticsEntry: DiagnosticsEntry) {
if (isAndroidNOrNewer()) {
val anonymizedEvent = diagnosticsAnonymizer.anonymizeEntryIfNeeded(diagnosticsEntry)
verboseLog("Tracking diagnostics entry: $anonymizedEvent")
verboseLog("Tracking diagnostics entry: $diagnosticsEntry")
try {
diagnosticsFileHelper.appendEvent(anonymizedEvent)
diagnosticsFileHelper.appendEvent(diagnosticsEntry)
} catch (e: IOException) {
verboseLog("Error tracking diagnostics entry: $e")
}
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package com.revenuecat.purchases.common.diagnostics

import android.content.Context
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.revenuecat.purchases.common.Anonymizer
import com.revenuecat.purchases.common.FileHelper
import com.revenuecat.purchases.common.SyncDispatcher
import io.mockk.every
Expand Down Expand Up @@ -41,7 +40,6 @@ class DiagnosticsTrackerFunctionalTest {
diagnosticsTracker = DiagnosticsTracker(
appConfig = mockk(),
diagnosticsFileHelper = diagnosticsFileHelper,
diagnosticsAnonymizer = DiagnosticsAnonymizer(Anonymizer()),
diagnosticsHelper = DiagnosticsHelper(applicationContext, diagnosticsFileHelper, lazy { mockk(relaxed = true) }),
diagnosticsDispatcher = SyncDispatcher(),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@ import android.content.SharedPreferences
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.revenuecat.purchases.CustomerInfo
import com.revenuecat.purchases.EntitlementInfos
import com.revenuecat.purchases.PurchasesAreCompletedBy
import com.revenuecat.purchases.PurchasesAreCompletedBy.MY_APP
import com.revenuecat.purchases.PurchasesError
import com.revenuecat.purchases.PurchasesErrorCode
import com.revenuecat.purchases.Store
import com.revenuecat.purchases.VerificationResult
import com.revenuecat.purchases.common.Anonymizer
import com.revenuecat.purchases.common.AppConfig
import com.revenuecat.purchases.common.Dispatcher
import com.revenuecat.purchases.common.PlatformInfo
Expand All @@ -28,7 +26,6 @@ import io.mockk.mockk
import io.mockk.mockkStatic
import io.mockk.unmockkStatic
import io.mockk.verify
import io.mockk.verifyOrder
import io.mockk.verifySequence
import org.junit.After
import org.junit.Before
Expand Down Expand Up @@ -82,7 +79,6 @@ class DiagnosticsTrackerTest {
diagnosticsTracker = DiagnosticsTracker(
appConfig,
diagnosticsFileHelper,
DiagnosticsAnonymizer(Anonymizer()),
DiagnosticsHelper(mockk(), diagnosticsFileHelper, lazy { sharedPreferences }),
dispatcher
)
Expand Down