Diagnostics: Remove unused anonymizer #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 223 221 -2
Lines 7673 7654 -19
Branches 1078 1074 -4
==========================================
- Hits 6359 6343 -16
+ Misses 893 892 -1
+ Partials 421 419 -2 ☔ View full report in Codecov by Sentry. |
JayShortway
reviewed
Jul 29, 2024
There was a problem hiding this comment.
PurchasesConfiguration.diagnosticsEnabled() has the following line in the docs:
This information will be anonymized so it can't be traced back to the end-user.
Should we remove or reword that? We could say something like:
No personal identifiable information will be collected.
Other than that it looks good to me!
|
Ah great catch! Yeah, that would be better, fixing! |
tonidero
pushed a commit
that referenced
this pull request
Aug 1, 2024
**This is an automatic release.** ### New Features * Adds pricePerPeriod functions to PricingPhase (#1789) via JayShortway (@JayShortway) ### Dependency Updates * Bump rexml from 3.2.9 to 3.3.2 (#1788) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.221.1 to 2.222.0 (#1797) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Adds the baseline file to the Detekt IntelliJ plugin settings. (#1798) via JayShortway (@JayShortway) * Adds the Detekt IntelliJ plugin settings to version control. (#1796) via JayShortway (@JayShortway) * Diagnostics: Remove unused anonymizer (#1795) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Anonymizerwas unused and we don't plan to track any sort of PII with this feature, so removing this code for now.