Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison of branch: backports-release-1.9+RAI #45

Closed
wants to merge 48 commits into from

Conversation

quinnj
Copy link

@quinnj quinnj commented Sep 11, 2023

Corresponding RAICode PR that tracks this: https://github.com/RelationalAI/raicode/pull/15321

@quinnj quinnj changed the title Comparison of _release_ branch: v1.9.3 and _target_ branch: backports-release-1.9+RAI Comparison of release branch: v1.9.3 and target branch: backports-release-1.9+RAI Sep 11, 2023
@quinnj quinnj changed the title Comparison of release branch: v1.9.3 and target branch: backports-release-1.9+RAI Comparison of release branch: v1.9.3+RAI and target branch: backports-release-1.9+RAI Sep 11, 2023
@nickrobinson251 nickrobinson251 marked this pull request as draft September 14, 2023 09:19
@nickrobinson251 nickrobinson251 changed the base branch from v1.9.3+RAI to backports-release-1.9 September 15, 2023 10:44
@nickrobinson251 nickrobinson251 changed the title Comparison of release branch: v1.9.3+RAI and target branch: backports-release-1.9+RAI Comparison of branch: backports-release-1.9+RAI Sep 15, 2023
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch 2 times, most recently from f9f1f3b to 591450c Compare October 1, 2023 00:17
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch 4 times, most recently from 270d132 to 3297047 Compare October 18, 2023 00:15
@kpamnany kpamnany force-pushed the backports-release-1.9+RAI branch 3 times, most recently from 6d650c9 to 3166a6c Compare October 19, 2023 18:27
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch from 3166a6c to cac5c2a Compare October 20, 2023 16:48
@kpamnany kpamnany force-pushed the backports-release-1.9+RAI branch from cac5c2a to c513b80 Compare October 21, 2023 20:32
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch from c513b80 to f3980e1 Compare October 23, 2023 20:05
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch 2 times, most recently from 7375465 to 5dc1feb Compare November 2, 2023 00:15
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch from 5dc1feb to 52de49f Compare November 7, 2023 00:15
Backported PRs:
- [x] JuliaLang#49357 <!-- Fix unclosed code fence in src/manual/methods.md -->
- [x] JuliaLang#50842 <!-- Avoid race conditions with recursive rm -->
- [x] JuliaLang#50858 <!-- Add a `threadpool` parameter to `Channel` constructor
-->
- [x] JuliaLang#50730 <!-- Fix integer overflow in `isapprox` -->
- [x] JuliaLang#50823 <!-- Make ranges more robust with unsigned indexes. -->
- [x] JuliaLang#50915 <!-- Add note the `Task` about sticky bit -->
- [x] JuliaLang#50989 <!-- fix incorrect results in `expm1(::Union{Float16,
Float32})` -->
- [x] JuliaLang#50912 <!-- Separate foreign threads into a :foreign threadpool
-->
- [x] JuliaLang#51019 <!-- fix a case of potentially use of undefined variable
when handling error in distributed message processing -->
- [x] JuliaLang#51222 <!-- Check again if the tty is open inside the IO lock -->
- [x] JuliaLang#51254 <!-- Ryu: make sure adding zeros does not overwrite
trailing dot -->
- [x] JuliaLang#51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple
-->
- [x] JuliaLang#51491 <!-- Throw clearer ArgumentError for strip with two string
args -->
- [x] JuliaLang#51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe
download error) -->
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch from 52de49f to 21e13d2 Compare November 10, 2023 19:21
Backports a single commit to Pkg
(JuliaLang/Pkg.jl#3696) which caused Pkg
parallel precompile to sometimes recompile packages that were already
compiled.
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch from 21e13d2 to ace05c4 Compare November 14, 2023 00:16
vtjnash and others added 13 commits November 15, 2023 00:16
As that PR is not in 1.9.
In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.
* Emit safepoints at function entry

* Make safepoint emission on function entry a codegen feature

* Hoist signal page lookup outside fence

* Update src/cgutils.cpp

* Fix rebase
Extend the fix for JuliaLang#43578 (2939272) to
cover the deadlock bug present internally in dyld4 inside the function
we use to avoid the previous deadlock issue.

Fix JuliaLang#49733
Presence is controlled by a build-time option. Start a separate
thread which simply sleeps. When heartbeats are enabled, this
thread wakes up at specified intervals to verify that user code
is heartbeating as requested and if not, prints task backtraces.

Also fixes the call to `maxthreadid` in `generate_precompile.jl`.
@DelveCI DelveCI force-pushed the backports-release-1.9+RAI branch from ace05c4 to 2e444bf Compare November 15, 2023 00:16
gbaraldi and others added 12 commits December 7, 2023 13:13
…106)

Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
When enabling heartbeats, the user must specify:
- heartbeat_s: jl_heartbeat() must be called at least once every heartbeat_s; if it
  isn't, a one-line heartbeat loss report is printed
- show_tasks_after_n: after these many heartbeat_s have passed without jl_heartbeat()
  being called, print task backtraces and stop all reporting
- reset_after_n: after these many heartbeat_s have passed with jl_heartbeat()
  being called, print a heartbeats recovered message and reset reporting
…uliaLang#52164) (#112)

One of the limitations is that it's only accurate right after the GC.
Still might be helpful for observability purposes.
…111)

We're suffering from heavy fragmentation in some of our workloads.

Add a build-time option to enable 4k pages (instead of 16k) in the GC,
since that improves memory utilization considerably for us.

Drawback is that this may increase the number of `madvise` system calls
in the sweeping phase by a factor of 4, but concurrent page sweeping
should help with some of that.
Also initialize it later, outside option parsing, so that modifying jl_options
before calling jl_init works.

Co-authored-by: Jeff Bezanson <[email protected]>
Copy link

github-actions bot commented Feb 2, 2024

This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days.

@github-actions github-actions bot added the stale This pull request is inactive label Feb 2, 2024
@github-actions github-actions bot closed this Feb 8, 2024
NHDaly pushed a commit that referenced this pull request May 17, 2024
Without this change, the compiler fails to notice that `env_threads isa
Int` in the fall-through case, leading to a union-split with a branch
that is in fact unreachable:

```
43 ┄ %109 = φ (#41 => %105, #42 => %108)::Union{Nothing, Int64}
│    %110 = (%109 isa Int64)::Bool
└───        goto #45 if not %110
...
45 ─ %126 = π (%109, Nothing)
│           Base.convert(Int64, %126)::Union{}
└───        unreachable
```

After this change, the union-split is eliminated.

Co-authored-by: Jeff Bezanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This pull request is inactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.