eagerly update pool live bytes metric #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
|
If we can merge the upstream PR and just cherry-pick that commit here, it would leave us a cleaner history. |
|
Sounds good. |
|
PR has been merged upstream without any changes. Could you approve it? |
kpamnany
approved these changes
Nov 5, 2023
kpamnany
removed
the
port-to-v1.10
Drvi
added
port-to-v1.9
d-netto
added a commit
that referenced
this pull request
Dec 7, 2023
Drvi
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
pool_live_byteswas previously lazily updated during the GC, meaning it was only accurate right after a GC.Make this metric accurate if gathered after a GC has happened.
Checklist
Requirements for merging:
port-to-*labels that don't apply.