Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review the examples for v0.2.x #34

Closed
Raffaello opened this issue Apr 30, 2020 · 0 comments · Fixed by #31
Closed

review the examples for v0.2.x #34

Raffaello opened this issue Apr 30, 2020 · 0 comments · Fixed by #31
Assignees
@Raffaello
Labels
examples related to examples how to use the lib
Milestone
Version 0.2.1

Comments

@Raffaello
Copy link
Owner

the example might be slightly outdated and not tidy up.

so just put them in tune with the v0.2.x
Raffaello added a commit that referenced this issue May 1, 2020
@Raffaello
review examples. Fixes #34
1587146
@Raffaello Raffaello self-assigned this May 1, 2020
@Raffaello Raffaello added this to the Version 0.2 milestone May 1, 2020
@Raffaello Raffaello linked a pull request May 1, 2020 that will close this issue
v0.2.1 #31
Merged
@Raffaello Raffaello added the examples related to examples how to use the lib label May 1, 2020
Raffaello added a commit that referenced this issue May 1, 2020
@Raffaello
v0.2.1 (#31)
96d3f72 
* fix #29. add patch number to versioning

* fix #32

* remove cmake library obj as redundant

* simplified cmake

* add generated cmake version file #33

* fix #33. typo in var usage

* refacto test, partial fix #30: blinking cursor tests

* cursor shape snapshot tests. fix #30

* enforce display cursor when changing status. Fix #26

* add noexcept to _busy method #26

* [WIP] remove mutex and replaced with atomic operations.

* cleanups #26

* more cleanups #26

* fix linux/GCC build

* fix cmake configuration with SDL2-static lib

* helgrind test and related data races fixes #27

* remove atomic array and replace reads/writes with a mutex. Fixes #27

* rename WITH_* to BUILD_* were approprioate in cmake config. Fixes #35

* dependent option TEST_DUMP_SNAPSHOT. Fixes #36

* review examples. Fixes #34

* codacy code review

* keep unused var declaration

* rename _busy method to _setBusy, add isIdle method and test. #26

* Update CMakeLists.txt

* code rev, fix wrong cmake option logic WITH_SDL2_STATIC

* Apply suggestions from code review

* Apply suggestions from code review

* Update sdl2-vga-terminal/examples/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
examples related to examples how to use the lib
Projects
None yet
Milestone
Version 0.2.1
Development

Successfully merging a pull request may close this issue.

v0.2.1 Raffaello/sdl2-vga-terminal
1 participant
@Raffaello