Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create test for concurrency and fix possible issues found #27

Closed
Raffaello opened this issue Apr 26, 2020 · 2 comments · Fixed by #31
Closed

create test for concurrency and fix possible issues found #27

Raffaello opened this issue Apr 26, 2020 · 2 comments · Fixed by #31
Assignees
@Raffaello
Labels
bug Something isn't working enhancement New feature or request
Milestone
Version 0.2.1

Comments

@Raffaello
Copy link
Owner

until now waiting an event before doing anything, was not really triggering anything about concurrency concern.

write some concurrency test around the aspect involving the timer variables.
@Raffaello Raffaello self-assigned this Apr 26, 2020
@Raffaello Raffaello added the enhancement New feature or request label Apr 26, 2020
@Raffaello Raffaello added this to the Version 0.2 milestone Apr 26, 2020
@Raffaello Raffaello added the bug Something isn't working label Apr 30, 2020
@Raffaello Raffaello linked a pull request Apr 30, 2020 that will close this issue
v0.2.1 #31
Merged
@Raffaello Raffaello changed the title create an example with poll events and test for concurrency create test for concurrency Apr 30, 2020
@Raffaello Raffaello changed the title create test for concurrency create test for concurrency and fix possible issues found Apr 30, 2020
@Raffaello
Copy link
Owner Author

using helgrind for detecting data races conditions.

Raffaello added a commit that referenced this issue Apr 30, 2020
@Raffaello
helgrind test and related data races fixes #27
be5db37
Raffaello added a commit that referenced this issue Apr 30, 2020
@Raffaello
remove atomic array and replace reads/writes with a mutex. Fixes #27
12ca16e
@Raffaello Raffaello mentioned this issue May 1, 2020
Open
@Raffaello
Copy link
Owner Author

Raffaello commented May 1, 2020 •
edited
Loading

it is still missing to run multiple threads accessing the same terminal, but it is not the aim of this issue for the current version at the moment.

Raffaello added a commit that referenced this issue May 1, 2020
@Raffaello
v0.2.1 (#31)
96d3f72 
* fix #29. add patch number to versioning

* fix #32

* remove cmake library obj as redundant

* simplified cmake

* add generated cmake version file #33

* fix #33. typo in var usage

* refacto test, partial fix #30: blinking cursor tests

* cursor shape snapshot tests. fix #30

* enforce display cursor when changing status. Fix #26

* add noexcept to _busy method #26

* [WIP] remove mutex and replaced with atomic operations.

* cleanups #26

* more cleanups #26

* fix linux/GCC build

* fix cmake configuration with SDL2-static lib

* helgrind test and related data races fixes #27

* remove atomic array and replace reads/writes with a mutex. Fixes #27

* rename WITH_* to BUILD_* were approprioate in cmake config. Fixes #35

* dependent option TEST_DUMP_SNAPSHOT. Fixes #36

* review examples. Fixes #34

* codacy code review

* keep unused var declaration

* rename _busy method to _setBusy, add isIdle method and test. #26

* Update CMakeLists.txt

* code rev, fix wrong cmake option logic WITH_SDL2_STATIC

* Apply suggestions from code review

* Apply suggestions from code review

* Update sdl2-vga-terminal/examples/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Version 0.2.1
Development

Successfully merging a pull request may close this issue.

v0.2.1 Raffaello/sdl2-vga-terminal
1 participant
@Raffaello