Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve compiler warnings #146

Closed
3 tasks done
Raffaello opened this issue May 21, 2020 · 0 comments
Closed
3 tasks done

resolve compiler warnings #146

Raffaello opened this issue May 21, 2020 · 0 comments
Assignees
Labels
refactor improve the code without enhancing in functionalities
Milestone

Comments

@Raffaello
Copy link
Owner

Raffaello commented May 21, 2020

there are multiple compilers warnings with the TUI draft introduction

  • MSVC
  • GCC
  • clang

as much as possible, some are not "resolvable" and can just be ignored.

@Raffaello Raffaello added the refactor improve the code without enhancing in functionalities label May 21, 2020
@Raffaello Raffaello added this to the Version 0.3.0 milestone May 21, 2020
@Raffaello Raffaello self-assigned this May 21, 2020
@Raffaello Raffaello mentioned this issue May 21, 2020
9 tasks
Raffaello added a commit that referenced this issue May 22, 2020
Raffaello added a commit that referenced this issue May 22, 2020
* preparing for v0.3.0

* rebase

* add clearLine method. fix #42

* update readme. fix #121

* for loop refactor in a C++ way

* refactor _setCharAtCursorPosition name

* refactor clearLine

* add fill method. Fix #113

* decouple VgaTerminal drawing functionality to Window. Fix #122

* cursor blinking flag. Fix #39

* cursor speed from enum class, partially fix #38

* [cmake] macro to generate example. Fix #126

* update version string to 0.3.0 fixes #129

* build switch for precise timer,fixes #131 cursor blinking test macOS

* replace -fPIC with CMAKE_POSITION_INDEPENDENT_CODE flag. fix #132

* [appveyor | macOS] disable precise timer fix #131

* [TuiTerminal] phase 1 ver 0.1-showcase and example. Fixes #133

* [cmake] using GoogleTest module and macro for test. Fixes#128

* TODOs review

* define specific runtime_error exception. Fixes # 139

* fixes #91

* [wont fix] snapshot testing on CI. Fixes #141

* publish test report and code coverage on analysis pipeline. Fixes #143

* publish test reports even if test task failed. Fixes #130

* add .gittribute

* [lint] line ending LF

* [lint] replace TABS with SPACES

* [lint] end line LF. [azure-pipelines] cpplint analisys

* [azure-pipelines] add cpplint job. Fixes #140

* compilers warning fixes #146

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor improve the code without enhancing in functionalities
Projects
None yet
Development

No branches or pull requests

1 participant