Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci | testing ] enable snapshot testing #141

Closed
Raffaello opened this issue May 20, 2020 · 2 comments
Closed

[ci | testing ] enable snapshot testing #141

Raffaello opened this issue May 20, 2020 · 2 comments
Assignees
@Raffaello
Labels
configuration cmake or project related code, configuaration refactor improve the code without enhancing in functionalities wontfix This will not be worked on
Milestone
Version 0.3.0

Comments

@Raffaello
Copy link
Owner

in windows, and try fix in macOS..

the macOs in CI, probably also due to software rendering,
has a different pixel format for the loaded image SDL_PIXELFORMAT_BGRA32

i think it can be ignored that expectation, at the same time i have no way to reproduce it... and puzzled why a loaded image should have a different format.

This could also lead to a different palete, colors, in macOS, but again i cannot really test without a mac.... but should not as it is the loaded image that as a different expect format, when it is the constant here in the text.

as a quick solution i can just comment out that expected test line.
@Raffaello Raffaello added this to the Version 0.3.0 milestone May 20, 2020
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
3f18d30
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
a5cc002
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
8562b07
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
4cf8a3f
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
b427a37
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
ef8b58a
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
e81f072
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
8a580e8
@Raffaello Raffaello added configuration cmake or project related code, configuaration refactor improve the code without enhancing in functionalities wontfix This will not be worked on labels May 20, 2020
@Raffaello Raffaello self-assigned this May 20, 2020
@Raffaello
Copy link
Owner Author

unfortunately the screen is black when doing the test on macOS... like is not rendered in time.
i am doing the last test adding 1s delay between the render method and checks.

Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
10e95c8
@Raffaello
Copy link
Owner Author

maybe with even more than 1s would work, but i won't do that... so this wontfix

Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
666630e
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
enabling snapshot testing on CI. Fixes #141
2665a53
@Raffaello Raffaello reopened this May 20, 2020
Raffaello added a commit that referenced this issue May 20, 2020
@Raffaello
[wont fix] snapshot testing on CI. Fixes #141
5b8d806
@Raffaello Raffaello mentioned this issue May 21, 2020
Merged
9 tasks
Raffaello added a commit that referenced this issue May 22, 2020
@Raffaello
v0.3.0 (#86)
777012d 
* preparing for v0.3.0

* rebase

* add clearLine method. fix #42

* update readme. fix #121

* for loop refactor in a C++ way

* refactor _setCharAtCursorPosition name

* refactor clearLine

* add fill method. Fix #113

* decouple VgaTerminal drawing functionality to Window. Fix #122

* cursor blinking flag. Fix #39

* cursor speed from enum class, partially fix #38

* [cmake] macro to generate example. Fix #126

* update version string to 0.3.0 fixes #129

* build switch for precise timer,fixes #131 cursor blinking test macOS

* replace -fPIC with CMAKE_POSITION_INDEPENDENT_CODE flag. fix #132

* [appveyor | macOS] disable precise timer fix #131

* [TuiTerminal] phase 1 ver 0.1-showcase and example. Fixes #133

* [cmake] using GoogleTest module and macro for test. Fixes#128

* TODOs review

* define specific runtime_error exception. Fixes # 139

* fixes #91

* [wont fix] snapshot testing on CI. Fixes #141

* publish test report and code coverage on analysis pipeline. Fixes #143

* publish test reports even if test task failed. Fixes #130

* add .gittribute

* [lint] line ending LF

* [lint] replace TABS with SPACES

* [lint] end line LF. [azure-pipelines] cpplint analisys

* [azure-pipelines] add cpplint job. Fixes #140

* compilers warning fixes #146

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
configuration cmake or project related code, configuaration refactor improve the code without enhancing in functionalities wontfix This will not be worked on
Projects
None yet
Milestone
Version 0.3.0
Development

No branches or pull requests
1 participant
@Raffaello