Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement configurable OCR skip options (closing #129) #164

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Implement configurable OCR skip options (closing #129) #164

merged 2 commits into from
Nov 21, 2022

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Nov 15, 2022

No description provided.

@R0Wi R0Wi requested a review from bahnwaerter November 15, 2022 15:41
@R0Wi R0Wi linked an issue Nov 15, 2022 that may be closed by this pull request
Make OCR skip options configurable #129
Closed
3 tasks
@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Merging #164 (242e607) into master (8cfba2c) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #164   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       166       170    +4     
===========================================
  Files             34        34           
  Lines            610       620   +10     
  Branches           4         6    +2     
===========================================
+ Hits             610       620   +10
Impacted Files Coverage Δ
lib/Model/WorkflowSettings.php 100.00% <100.00%> (ø)
lib/OcrProcessors/OcrMyPdfBasedProcessor.php 100.00% <100.00%> (ø)
src/components/WorkflowOcr.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bahnwaerter
bahnwaerter approved these changes Nov 20, 2022
View reviewed changes
Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I left a small comment about a possible name change of a data structure. This would make the code easier to understand.

Note that I only reviewed the code of the changes and did not do a final test on a fresh Nextcloud instance.

lib/OcrProcessors/OcrMyPdfBasedProcessor.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@R0Wi R0Wi merged commit 9015333 into master Nov 21, 2022
@R0Wi R0Wi deleted the impl#129 branch November 21, 2022 06:14
@R0Wi R0Wi mentioned this pull request Nov 21, 2022
Merged
R0Wi added a commit that referenced this pull request Nov 21, 2022
@R0Wi @github-actions
Implement configurable OCR skip options (closing #129) (#164)
9ce4fa6 
* Implement configurable OCR skip options (closing #129)

* Minor naming and code improvements
R0Wi added a commit that referenced this pull request Nov 21, 2022
@R0Wi
Implement configurable OCR skip options (closing #129) (#164) (#165)
23ec75d 
* Implement configurable OCR skip options (closing #129)

* Minor naming and code improvements
bahnwaerter
bahnwaerter reviewed Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, everything seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahnwaerter bahnwaerter bahnwaerter approved these changes

Assignees
No one assigned
Labels
backport stable25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make OCR skip options configurable
2 participants
@R0Wi @bahnwaerter