Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OCR skip options configurable #129

Closed
3 tasks done
R0Wi opened this issue Jun 18, 2022 · 2 comments · Fixed by #164
Closed
3 tasks done

Make OCR skip options configurable #129

R0Wi opened this issue Jun 18, 2022 · 2 comments · Fixed by #164
Labels
enhancement New feature or request

Comments

@R0Wi
Copy link
Contributor

R0Wi commented Jun 18, 2022

As a result of #113 we should make the options --skip-text, --redo-ocr and --force-ocr configurable through our per workflow settings UI. Also we should have an option so choose none of these parameters (see #130)

  • Add a flag to the model
  • Add radiobuttons to per workflow settings UI
  • Make redo-ocr mutially exclusive with remove-background (latter is not possible in redo-ocr-mode)
@jkumeboshi
Copy link

With skip-text as default, documents created with camscanner or other similar SW adding some text to the scanned images fails ("scanned with CamScanner" is enough to stop the skip-text option).

I think that this setting could be added to the workflow settings.
So I would create 2 kind of tag forkflow: 1 with redo-ocr or force-ocr and another with skip-text
So I could use the force-ocr workflow with documents coming from camscanner

@R0Wi
Copy link
Contributor Author

R0Wi commented Nov 17, 2022

@jkumeboshi I implemented the configuration possibility now. Could you image beta testing the new feature and give me some feedback?

@R0Wi R0Wi closed this as completed in #164 Nov 21, 2022
R0Wi added a commit that referenced this issue Nov 21, 2022
* Implement configurable OCR skip options (closing #129)

* Minor naming and code improvements
R0Wi added a commit that referenced this issue Nov 21, 2022
* Implement configurable OCR skip options (closing #129)

* Minor naming and code improvements
R0Wi added a commit that referenced this issue Nov 21, 2022
* Implement configurable OCR skip options (closing #129)

* Minor naming and code improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants