Revised summary indices - removed and updated old values #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for testing Analysis Programs
This reverts commit c5fa3cb.
Checking the combine effect of the most recent merge. Four small changes: 1. Adjusted max bound of Clipping Index 2. Chnaged paths in Sandpit.cs for testing 3. Added two new RGB index combinations. 4. Added (Action) cast to enable build.
Separate out the Channel Integrity indices from the standard Summary Indices. Now have a separate IndexProperties file for channel integrity indices. Also change Bounds for the clipping index.
Removed IncludeInComboIndex & ComboWeight as Index properties. Removed six unused indices from the IndexProperties config file, including Rain and Cicadas. Remove BGN string constant. remove two tests for now deleted Indices. Shifted method ConvertToDictionaryOfSummaryIndices() and related method to class SummaryIndexValues because this was more suitable location ie dealing with dictiionaries of arrays, not matrices.
No longer needed. Also do some resharper stuff
Also clean up commented code.
Most of the issues have been resolved. BUT..... Did NOT generalise the method SummaryIndexvalues.GetDictionaryOfSummaryIndices(List<SummaryIndexValues> summaryIndices) Anhtony will have to do this. I have increased the number of summary indices displayed.
remove two of the summary indices for display.
Changed tests to accomodate changed files numbers and content. Changed Consine to Cosine - this affect several methods
Use the full range of the y-axis scale when drawing histogram. Add the number of the modal bin to the collected statistics. Change method arguments to accept modalBin. Remove duplicated lines from SpectrogramConstants.cs. Write SandPit method to test drawing of histograms. this can be turned into a unit test. NOTE: The "gap" in the histograms noted in Issue #186 is due to way Rectangular bars were drawn. Nothing to do with inadequate size of int.
Where mode of distribution = 0.0, this will contribute to suboptimal colour rendering of histograms. Start work on setting modal value > 0.0.
One reason for suboptimal rendering of LFFC spectrograms is that in some cases the mode of the distribution of index values is also the minimum, expecially in case of Entropy where mode often = zero. When tihs occur, now prevent mode being in the bottom two histogram bins. Most of the other changes are resharper inspired or designed to simplify code.
Fix tests where there was incorrect assertion of colour.
Issue #186 Suboptimal LDFCs
ConcatenateIndexFiles now removes duplicate files from the directory search. This makes it wasier to omit the directory filter argument which does not have enough expressiveness to select all relevant directories, while not including sub-directories - which would lead to "System.ArgumentException: An entry with the same key already exists." errors. If there are legitimately duplicate dates, I've changed the code so it returns a better, more readable error.
atruskie
changed the title
Separate out the Channel Integrity indices from the standard Summary Indices. Now have a separate IndexProperties file for channel integrity indices. Also change Bounds for the clipping index.
Removed IncludeInComboIndex & ComboWeight as Index properties. Removed six unused indices from the IndexProperties config file, including Rain and Cicadas. Remove BGN string constant. remove two tests for now deleted Indices. Shifted method ConvertToDictionaryOfSummaryIndices() and related method to class SummaryIndexValues because this was more suitable location ie dealing with dictiionaries of arrays, not matrices.
No longer needed. Also do some resharper stuff
Also clean up commented code.
Most of the issues have been resolved. BUT..... Did NOT generalise the method SummaryIndexvalues.GetDictionaryOfSummaryIndices(List<SummaryIndexValues> summaryIndices) Anhtony will have to do this. I have increased the number of summary indices displayed.
remove two of the summary indices for display.
Changed tests to accomodate changed files numbers and content. Changed Consine to Cosine - this affect several methods
…acoustics/audio-analysis into SummaryIndices-Issue-#217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the expected test results for the three tests that were failing.
Closes #217