Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for writing Summary Index file and Images is overly complex #217

Closed
towsey opened this issue Feb 13, 2019 · 0 comments · Fixed by #228
Closed

Code for writing Summary Index file and Images is overly complex #217

towsey opened this issue Feb 13, 2019 · 0 comments · Fixed by #228
Assignees

Comments

@towsey
Copy link
Contributor

towsey commented Feb 13, 2019

Describe the bug

The code for the writing of summary indices to csv file and for the presentation of image tracks is unnecessarily complicated. There are three issues:

  1. The initial writing of the Summary indices to csv file includes three unnecessary columns containing zeros. Columns are P, R and T and header names are AvgEntropySpectrum, VarianceentropySpectrum and EntropyPeaks. these are just the old names for the indices that are now written to Columns O, Q, and S respectively.

  2. There are many unnecessary inclusions (e.g. zero crossings in the L and R channels) in the IndexProperties file resulting from work done with Yvonne Philips checking for channel integrity. these are special case indices and not usually required.

  3. The translation dictionary is no longer useful and should be removed.

Describe the solution you'd like

  1. Refactor the SummaryIndexValues class to remove writing of unnecessary columns to csv file
  2. Take out all indices in the IndexProperties config file to do with channel integrity and put them in a separate Properties file.
  3. remove the implementation of the Translation Dictionary.
towsey added a commit that referenced this issue Feb 14, 2019
Most of the issues have been resolved.
BUT.....
Did NOT generalise the method SummaryIndexvalues.GetDictionaryOfSummaryIndices(List<SummaryIndexValues> summaryIndices)

Anhtony will have to do this. I have increased the number of summary indices displayed.
towsey added a commit that referenced this issue Mar 14, 2019
Changed tests to accomodate changed files numbers and content.
Changed Consine to Cosine - this affect several methods
atruskie pushed a commit that referenced this issue Mar 25, 2019
Most of the issues have been resolved.
BUT.....
Did NOT generalise the method SummaryIndexvalues.GetDictionaryOfSummaryIndices(List<SummaryIndexValues> summaryIndices)

Anhtony will have to do this. I have increased the number of summary indices displayed.
atruskie pushed a commit that referenced this issue Mar 25, 2019
Changed tests to accomodate changed files numbers and content.
Changed Consine to Cosine - this affect several methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants