-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PrimitivesV1 reference implementations and their utils #12575
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9662438342Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- Revert BaseSamplerV1 and BaseEstimatorV1 - Deprecate BaseSampler and BaseEstimator Qiskit#12497 (comment)
I asked some questions about the agreement #12497 (comment). So, let's wait for answers about other base classes and the result classes. |
I reverted SamplerResult, EstimatorResult and BasePrimitive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes @t-imamichi, the deprecated classes seem to follow the recent discussion outcomes. The only missing point is fixing the current lint complaint, which I believe might require modifying the primitives __init__
to deal with the BaseEstimator
/BaseSampler
alias import (probably re-raising the warning in the __init__
? you may be able to find a better solution than me)
I thought the revised version of BaseSampler and BaseEstimator was smarter (copied #11054). But as CI showed, it caused complicated import issues. It's not easy for me to resolve because BaseSampler and BaseEstimator are imported by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the effort taking the PR past the finish line!
* Deprecate V1 Primitives and their utils * Fix tests * Fix yaml error * Fix build * Fix error after mc * Fix error after mc * Apply comments * Use correct deprecate version for warning message * Update deprecation messages * Add missed `` * update releasenote * Deprecate SamplerResult and EstimatorResult * fix deprecation warning for SamplerResult and EstimatorResult * apply review comments Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> * Applying the agreement of deprecations. - Revert BaseSamplerV1 and BaseEstimatorV1 - Deprecate BaseSampler and BaseEstimator Qiskit#12497 (comment) * revert SamplerResult, EstimatorResult, and BasePrimitiveResult * fix test_backend_sampler * revert tox.ini * revise deprecation warning for BaseSampler and BaseEstimator * update reno * revert BaseSampler and BaseEstimator --------- Co-authored-by: Takashi Imamichi <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
Fixes #12497
Summary
Deprecate
Update
Details and comments