Deprecate BasePrimitiveResult #11054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
the
Changelog: Deprecation
chriseclectic
requested review from
ikkoham,
t-imamichi and
a team
as code owners
|
One or more of the the following people are requested to review this:
|
jakelishman
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Also, given Ian's RFC, is it actually set in stone that these will be removed in the way they're being done here, or is there a chance that there will just be a completely disjoint versioned set of primitives APIs, in which case these needn't be so eagerly deprecated?
chriseclectic
force-pushed
the
dep-base-primitive-result
branch
from
d78dbc1 to
4bf64e6
Compare
|
@t-imamichi Updated this PR if you could re-review |
Pull Request Test Coverage Report for Build 7465611903Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Deprecates the unnecessary base class BasePrimitiveResult so we can have a clean break in defining new ones in Qiskit 1.0. Also deprecates the common utility methods `decompose`, `experiments`, and `num_experimetns` this base class adds to SamplerResult and EstimatorResult. Add jakes suggestion
chriseclectic
requested review from
nonhermitian,
eggerdj,
wshanks,
alexanderivrii,
ShellyGarion,
jyu00,
woodsp-ibm and
ElePT
as code owners
chriseclectic
force-pushed
the
dep-base-primitive-result
branch
from
4bf64e6 to
847e00b
Compare
ikkoham
approved these changes
Jan 12, 2024
ikkoham
pushed a commit
to ikkoham/qiskit-terra
that referenced
this pull request
Jan 17, 2024
Deprecates the unnecessary base class BasePrimitiveResult so we can have a clean break in defining new ones in Qiskit 1.0. Also deprecates the common utility methods `decompose`, `experiments`, and `num_experimetns` this base class adds to SamplerResult and EstimatorResult. Add jakes suggestion
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Deprecate BasePrimitiveResult (#11054) Deprecates the unnecessary base class BasePrimitiveResult so we can have a clean break in defining new ones in Qiskit 1.0. Also deprecates the common utility methods `decompose`, `experiments`, and `num_experimetns` this base class adds to SamplerResult and EstimatorResult. Add jakes suggestion * Remove deprecated features in 0.46 in Primitives * lint * lint --------- Co-authored-by: Christopher J. Wood <[email protected]> Co-authored-by: Matthew Treinish <[email protected]>
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the unnecessary base class BasePrimitiveResult so we can have a clean break in defining new ones in Qiskit 1.0. Also deprecates the common utility methods
decompose,experiments, andnum_experimetnsthis base class adds to SamplerResult and EstimatorResult.Details and comments