some new code #81
some new code #81
Conversation
Rewrite the camera code With the addition of new codes, and adjusting the code in a better way It is now easier to add new cameras to the code Add a list of all cameras with numbers, names and addresses Add a tablet and animation when opening the camera andyy code
for test isLeo(2, true)
|
Check remaining comments |
|
Is there any response to the request? |
|
If it does not fit the idea of the project, please close the request |
|
three months |
There was a problem hiding this comment.
Please fix the lint errors.
It looks like there are several new features and refactors in this PR. If you want faster reviews, consider breaking up your PRs into smaller bite sized chunks of one new feature, or one refactor. These large PRs can be difficult and time consuming to review with lots of back and forth comments.
| if not checkLeoAndOnDuty(source) then return end | ||
| TriggerClientEvent('police:client:ActiveCamera', source, args.camid) | ||
| TriggerClientEvent('police:client:showCamera', source) |
There was a problem hiding this comment.
Would this be better as a callback? I like to use events only when we expect/want multiple event handlers, but this seems to be more like a network function call use of events.
There was a problem hiding this comment.
A callback is only used when you expect to receive something back, otherwise you use events. So this is correct.
There was a problem hiding this comment.
Callback inherently are also just events, so it won't make a difference if you do use it aside from you using more resources to do the same thing
| end | ||
| return tostring(hours .. ':' .. minutes) | ||
|
|
||
| tabletProp = CreateObject(`prop_cs_tablet`, 0.0, 0.0, 0.0, true, true, false) |
There was a problem hiding this comment.
We shouldn't be creating networked props on the client as it is not compliant with entity lockdown mode. Instead, create it on the server.
There was a problem hiding this comment.
@1Evolve just this one and you should be good
|
Completed 4 months ago |
|
Closed as requested. |
Description
Rewrite the camera code
With the addition of new codes, and adjusting the code in a better way It is now easier to add new cameras to the code
Add a list of all cameras with numbers, names and addresses Add a tablet and animation when opening the camera andyy code
Checklist