Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: server side objects spawning #112

Merged
merged 24 commits into from
Jun 1, 2024
Merged

Conversation

artur-michalak
Copy link
Contributor

Description

The changes were inspired by spikes not working with qbx:bucketlockdownmode other than “inactive”.
The modification began with the optimization of spikes. Then the changes to spikes were integrated into object creation. Locales were changed to be compatible with the project standards. The “i” loop was applied, wherever it makes sense. Moved the plate prefix “LSPD” to the configuration.

Refactor is still in development, but invite you to test and verify the source code.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@artur-michalak
Copy link
Contributor Author

In this commit 4cb8989
a change from this PR was used #86
Thanks to bicatcho11 for the PR.

@artur-michalak
Copy link
Contributor Author

Should #81 be integrated with this PR?

@Manason
Copy link
Contributor

Manason commented May 29, 2024

Should #81 be integrated with this PR?

This PR is already massive. Maybe do it in a separate one?

@artur-michalak artur-michalak marked this pull request as ready for review May 29, 2024 23:02
Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring code should be split from the new code. If it's too difficult to do so at this point fine, but please keep PRs small in the future as this is too large to review properly.

@artur-michalak
Copy link
Contributor Author

The refactoring code should be split from the new code. If it's too difficult to do so at this point fine, but please keep PRs small in the future as this is too large to review properly.

I know, the most messy part is the locales conversion.

@artur-michalak artur-michalak changed the base branch from main to staging May 30, 2024 17:01
@artur-michalak artur-michalak changed the base branch from staging to main May 30, 2024 17:02
@artur-michalak artur-michalak changed the title feat: refactor job feat: server side objects spawning May 30, 2024
@artur-michalak artur-michalak changed the base branch from main to staging May 31, 2024 10:22
@artur-michalak artur-michalak changed the base branch from staging to main May 31, 2024 10:22
@artur-michalak artur-michalak changed the base branch from main to staging May 31, 2024 10:24
@artur-michalak artur-michalak changed the base branch from staging to main May 31, 2024 10:31
@artur-michalak
Copy link
Contributor Author

there is no need to slim it down more

Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed remaining changes. Seems like an overall improvement

@Manason Manason merged commit 74ad35e into Qbox-project:main Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants