-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: server side objects spawning #112
Conversation
…actor: tabs to spaces
In this commit 4cb8989 |
Should #81 be integrated with this PR? |
This PR is already massive. Maybe do it in a separate one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring code should be split from the new code. If it's too difficult to do so at this point fine, but please keep PRs small in the future as this is too large to review properly.
I know, the most messy part is the locales conversion. |
…nd Remove feat: watchInVehicle only on isLoggedin event or vehicle cache change
refactor: policePlatePrefix loop to multiple lines
…hicle to displayInfoCloseToSpike
there is no need to slim it down more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed remaining changes. Seems like an overall improvement
Description
The changes were inspired by spikes not working with qbx:bucketlockdownmode other than “inactive”.
The modification began with the optimization of spikes. Then the changes to spikes were integrated into object creation. Locales were changed to be compatible with the project standards. The “i” loop was applied, wherever it makes sense. Moved the plate prefix “LSPD” to the configuration.
Refactor is still in development, but invite you to test and verify the source code.
Checklist