-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InterPro Release 101 #643
InterPro Release 101 #643
Conversation
Co-authored-by: Matthias Blum <[email protected]>
wikipedia links in caption
Co-authored-by: Matthias Blum <[email protected]>
Co-authored-by: Matthias Blum <[email protected]>
Ipscan infomessages
Feedback for entries
Ts SimpleTable
Additional links in interactions page
TS FullyLoadedTable
Ts table card
Co-authored-by: Matthias Blum <[email protected]>
Co-authored-by: Matthias Blum <[email protected]>
Ts table minor subcomponents
Ts table tree
…agments Get representative boolean from location instead of fragment
Sort InterPro releases by version number
Looking good overall, but I've got a few comments: Since we now have a "Feedback for entries button", I believe we could remove the "Provide feedback" from the warning message on AI-generated entries. There are some differences in the column names in tables throughout the website. I.e. some tables the column name in uppercase, other in lower case (e.g. pathways subpage) and others have some columns with upper case for the first letter, but other not (e.g. http://wp-np3-bd/interpro/entry/pfam/#table). It would be good to harmonise everything. I would suggest having only the first letter in upper case only. If the column is made of multiple words, the upper case should only be for the first word. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could replicate the wikipedia issues.
Otherwise looking good!
Thanks Typhaine
Cool. Found a bug and will puch a fix in a minute
The Feedback button is only visible for InterPro and Pfam, but there are AI descriptions in other member DBs, so I think the link should stay in the message.
OK I put a CSS rule to capitalize all table headers, however |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, you can merge the branch.
To be released together with InterPro 101.0 - Currently deployed in the Dev instance: http://wp-np3-bd/interpro/
Pull Requests
Most if not all have been reviewed in the following PRs:
Issues Fixed (Some not in PRs)