Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterPro Release 101 #643

Merged
merged 119 commits into from
Jul 23, 2024
Merged

InterPro Release 101 #643

merged 119 commits into from
Jul 23, 2024

Conversation

gustavo-salazar and others added 30 commits May 30, 2024 16:04
gustavo-salazar and others added 19 commits June 26, 2024 09:25
Additional links in interactions page
…agments

Get representative boolean from location instead of fragment
Sort InterPro releases by version number
@typhainepl
Copy link
Member

Looking good overall, but I've got a few comments:
At first, when I wanted to test the changes made to the Wikipedia section, the page was showing an error message and wasn't displaying the Wikipedia section, even after hard refresh, but after waiting sometime and accessing the page, it is now working for PF00001, but not for PF00003.

Since we now have a "Feedback for entries button", I believe we could remove the "Provide feedback" from the warning message on AI-generated entries.

There are some differences in the column names in tables throughout the website. I.e. some tables the column name in uppercase, other in lower case (e.g. pathways subpage) and others have some columns with upper case for the first letter, but other not (e.g. http://wp-np3-bd/interpro/entry/pfam/#table). It would be good to harmonise everything. I would suggest having only the first letter in upper case only. If the column is made of multiple words, the upper case should only be for the first word.

Copy link

@tgrego tgrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could replicate the wikipedia issues.
Otherwise looking good!

@gustavo-salazar
Copy link
Member Author

Thanks Typhaine

Looking good overall, but I've got a few comments: At first, when I wanted to test the changes made to the Wikipedia section, the page was showing an error message and wasn't displaying the Wikipedia section, even after hard refresh, but after waiting sometime and accessing the page, it is now working for PF00001, but not for PF00003.

Cool. Found a bug and will puch a fix in a minute

Since we now have a "Feedback for entries button", I believe we could remove the "Provide feedback" from the warning message on AI-generated entries.

The Feedback button is only visible for InterPro and Pfam, but there are AI descriptions in other member DBs, so I think the link should stay in the message.

There are some differences in the column names in tables throughout the website. I.e. some tables the column name in uppercase, other in lower case (e.g. pathways subpage) and others have some columns with upper case for the first letter, but other not (e.g. http://wp-np3-bd/interpro/entry/pfam/#table). It would be good to harmonise everything. I would suggest having only the first letter in upper case only. If the column is made of multiple words, the upper case should only be for the first word.

OK I put a CSS rule to capitalize all table headers, however capitalize also makes the first letter of second words uppercase, so not exactly how you wanted, but atlease this way all are harmonized. If you find one that is not please let me know. I'll deploy in wwwdev today so we can check the final version before release on Thursday

@gustavo-salazar gustavo-salazar merged commit 65fd645 into master Jul 23, 2024
3 checks passed
Copy link
Member

@typhainepl typhainepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, you can merge the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants