Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts table tree #632

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Ts table tree #632

merged 5 commits into from
Jul 4, 2024

Conversation

gustavo-salazar
Copy link
Member

Migration to typescript and visual framework for Table/view/Tree

  • Extracting Table/view/Tree/DataProvider

The pages/Taxonomy was also migrated, so you can use the Browse By Taxonomy to test the view.

Other changes:

  • Extracting Taxonomy/List from pages/Taxonomy
  • Extracting Taxonomy/ExactMatchSearch from pages/Taxonomy

Note: Seventh and last of a series of PRs chained to migrate <Table> and all its subcomponents. Make sure to review #631 first.

@coveralls
Copy link

Coverage Status

coverage: 22.977% (+0.9%) from 22.07%
when pulling 96cb4d5 on ts-table-tree
into f0cef8d on ts-table-sm.

@coveralls
Copy link

Coverage Status

coverage: 22.812% (+1.0%) from 21.804%
when pulling d0d72b4 on ts-table-tree
into 4388673 on ts-table-sm.

Copy link

@tgrego tgrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good!

Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Only issue is what @tgrego described in #631 (review), which will be fixed when merging #631 here.

@coveralls
Copy link

Coverage Status

coverage: 22.812% (+1.0%) from 21.804%
when pulling 52baa2d on ts-table-tree
into 4388673 on ts-table-sm.

@coveralls
Copy link

Coverage Status

coverage: 22.812% (+1.0%) from 21.804%
when pulling 52baa2d on ts-table-tree
into 4388673 on ts-table-sm.

Base automatically changed from ts-table-sm to dev July 3, 2024 12:30
@gustavo-salazar gustavo-salazar merged commit d3bf04e into dev Jul 4, 2024
3 checks passed
@matthiasblum matthiasblum deleted the ts-table-tree branch August 2, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants