Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 98 #565

Merged
merged 137 commits into from
Jan 18, 2024
Merged

Release 98 #565

merged 137 commits into from
Jan 18, 2024

Conversation

gustavo-salazar
Copy link
Member

matthiasblum and others added 30 commits November 22, 2023 00:12
@coveralls
Copy link

coveralls commented Jan 12, 2024

Coverage Status

coverage: 23.713% (+0.1%) from 23.594%
when pulling ea281fe on dev
into 02e21a1 on master.

Copy link
Member

@typhainepl typhainepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work! Overall everything seems to work fine. The only style issue I spotted is that on the Export menu, the Visual framework-styled buttons go outside the allocated area.
Example: image

Something I noticed is that when deleting one of the sequences in the batch search and downloading through the Group actions, the sequence is still there. But I am not sure this is fixable.

One thing to work on for the next release will be to have the gene available in TSV and Fasta files.

@gustavo-salazar
Copy link
Member Author

@typhainepl I think by introducing that bug I should get one of these mugs:
CSS is Awesome

Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A bunch of minor styling suggestions (non related to the PR):

@gustavo-salazar
Copy link
Member Author

A bunch of minor styling suggestions

I just include those changes. However, I only removed the border thing underlining the card titles. I'll review more about it whenever I do the migration to TS for those.

@typhainepl
Copy link
Member

typhainepl commented Jan 15, 2024

I just came across an issue with the relationship between entries in the clan Overview, the links between the nodes aren't shown anymore and the nodes are spaced equally from each other (e.g. cl00011)

@gustavo-salazar
Copy link
Member Author

I just came across an issue with the relationship between entries in the clan Overview, the links between the nodes aren't shown anymore and the nodes are spaced equally from each other (e.g. cl00011)

It's a data problem. But I think that test databases are being refreshed because of the upcoming release.

@gustavo-salazar gustavo-salazar merged commit 8e0cb2b into master Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants