-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 98 #565
Release 98 #565
Conversation
…bTeam/interpro7-client into ipscan-batch-download
Co-authored-by: Matthias Blum <[email protected]>
Co-authored-by: Matthias Blum <[email protected]>
…istent-categories
Ipscan batch download
Consistent categories
Co-authored-by: Matthias Blum <[email protected]>
Contact us page
Ts migrations for Menu
Gene in protein list and summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work! Overall everything seems to work fine. The only style issue I spotted is that on the Export menu, the Visual framework-styled buttons go outside the allocated area.
Example:
Something I noticed is that when deleting one of the sequences in the batch search and downloading through the Group actions
, the sequence is still there. But I am not sure this is fixable.
One thing to work on for the next release will be to have the gene
available in TSV and Fasta files.
@typhainepl I think by introducing that bug I should get one of these mugs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A bunch of minor styling suggestions (non related to the PR):
- Do not uppercase tooltip's titles in Tooltip/style.css.
- Add an
!important
aftertext-decoration
rules in interpro-vf.css. - Remove card-specific link styles as they clash with the new VF styles (e.g. bottom border and underline on hover)
- Add
.protvista-menu { margin-top: 0; }
to Table/Exporter/style.css to align the Export button with other components in the Browse page's table or grid.
I just include those changes. However, I only removed the border thing underlining the card titles. I'll review more about it whenever I do the migration to TS for those. |
I just came across an issue with the relationship between entries in the clan Overview, the links between the nodes aren't shown anymore and the nodes are spaced equally from each other (e.g. cl00011) |
It's a data problem. But I think that test databases are being refreshed because of the upcoming release. |
All the changes that were already reviewed in:
Note 1: Requires to be installed with npm7+ and node 18+
Note 2: Some features require the latest API changes in this PR
Note 3: Currently deployed in the future environment and should get automatically deployed in dev overnight