TS migration for Domain Architectures #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good. Made a few suggestions, but nothing major.
One thing I noticed is that when hovering domains in the Domain Architectures subpages (e.g. /interpro/entry/InterPro/IPR000001/domain_architecture/, the popup first appears on the top left on the viewport before being correctly placed next to the domain, e.g.:
Can you see if you can reproduce this behavior, and if so, can it be fixed?
Co-authored-by: Matthias Blum <[email protected]>
|
OK suggestions implemented. Except for the thing about the tooltip first appearing at the top of the screen. I don't really know why there is a delay in locating the tooltip in the right place on the page. But that will need more time to investigate. I'll create a GH issue about it. |
gustavo-salazar
force-pushed
the
IDA-TS-download
branch
from
c2e4295 to
ab432c9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript and visual framework migrations for the Domain architecture pages.
I'll work on the Download All DA, but I thought it would be easier to review if we separate the TS migration beforehand.
This doesn't include the interactive Search by IDA area, might do that one after the Download part if there is time left in this sprint.