Skip to content

Add tags and filtering for Affiliations #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 22, 2021

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Sep 16, 2021

This PR changes "affiliation" and "affiliation_url" to "institution" to free up the "affiliation" tag for ideas such as Pythia, Pangeo, Unidata etc.

So far only a few affiliations are added, just enough to test that our filtering menu html code automatically recognizes the new tag key (affiliation) and creates the new drop down menu.

There are also some changed files due to deleting the content repository to avoid confusion (redundant with PR #159)

Before we merge this, the EWG should have a conversation about what kinds of affiliation we want to support (hence the draft PR). Should we use the Pythia or Pangeo tag? both?

To Do: Update the Auto-PR bot for when commity member submit a resource to change "affiliation" to "institution" and add tag-key "affiliation."

Closes #156

@jukent jukent requested a review from a team as a code owner September 16, 2021 21:55
@jukent jukent requested review from brian-rose and kmpaul September 16, 2021 21:55
@jukent jukent marked this pull request as draft September 16, 2021 22:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2021

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: ce09362
✅ Deployment Preview URL: https://6171d6621818a00077da5b96--projectpythia-org.netlify.app

@jukent jukent marked this pull request as ready for review October 21, 2021 20:35
Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @jukent!

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@jukent jukent merged commit d21dffa into ProjectPythia:main Oct 22, 2021
@jukent jukent deleted the affiliation-tags branch October 22, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add affiliation filtering
3 participants