-
Notifications
You must be signed in to change notification settings - Fork 20
Add tags and filtering for Affiliations #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: ce09362 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @jukent!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
This PR changes "affiliation" and "affiliation_url" to "institution" to free up the "affiliation" tag for ideas such as Pythia, Pangeo, Unidata etc.
So far only a few affiliations are added, just enough to test that our filtering menu html code automatically recognizes the new tag key (affiliation) and creates the new drop down menu.
There are also some changed files due to deleting the content repository to avoid confusion (redundant with PR #159)
Before we merge this, the EWG should have a conversation about what kinds of affiliation we want to support (hence the draft PR). Should we use the Pythia or Pangeo tag? both?
To Do: Update the Auto-PR bot for when commity member submit a resource to change "affiliation" to "institution" and add tag-key "affiliation."
Closes #156