Skip to content

delete content directory #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2021
Merged

delete content directory #159

merged 2 commits into from
Sep 17, 2021

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Sep 16, 2021

content directory is deprecated, use portal directory instead. Deleting the content directory to reduce confusion.

@jukent jukent requested a review from a team as a code owner September 16, 2021 21:41
@jukent jukent requested review from ktyle, clyne and kmpaul September 16, 2021 21:41
kmpaul
kmpaul approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @jukent!

@jukent jukent mentioned this pull request Sep 16, 2021
Merged
@clyne
Copy link
Contributor

clyne commented Sep 16, 2021

This looks like an infrastructure change that I'm not familiar with; I'm not qualified to review. @ktyle are you comfortable with this?

@jukent
Copy link
Contributor Author

jukent commented Sep 16, 2021 •
edited
Loading

The site now builds from the portal directory. The content directory has no bearing on the site - but wasn't deleted immediately in case we had to revert something. The confusion between these two directories is why it took me a second attempt to get the changes in #147 to show up (they were all in the old content folder!)

@kmpaul is there anything else you want to say about this to help explain it?

@brian-rose brian-rose merged commit 24b289d into ProjectPythia:main Sep 17, 2021
@jukent jukent deleted the rm-content branch September 17, 2021 17:12
clyne added a commit that referenced this pull request Sep 17, 2021
@clyne
Revert "delete content directory (#159)"
f7d0021 
This reverts commit 24b289d.
@clyne clyne mentioned this pull request Sep 17, 2021
Closed
@jukent jukent added the infrastructure Infrastructure related issue label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clyne clyne clyne approved these changes

@kmpaul kmpaul kmpaul approved these changes

@ktyle ktyle Awaiting requested review from ktyle

Assignees
No one assigned
Labels
infrastructure Infrastructure related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jukent @clyne @kmpaul @brian-rose