Implement temporary workaround for race condition in REPL #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/workaround
branch
from
b1af397 to
c1906ce
Compare
daxian-dbw
approved these changes
Apr 26, 2022
andyleejordan
commented
Apr 27, 2022
| @@ -739,6 +739,11 @@ private void DoOneRepl(CancellationToken cancellationToken) | |||
| StopDebugContext(); | |||
| } | |||
|
|
|||
| if (cancellationToken.IsCancellationRequested) | |||
| { | |||
| return; | |||
There was a problem hiding this comment.
LMAO it did need this?!
|
Sounds like this might be replaced by PowerShell/PSReadLine#3294 (review) |
To unblock us, really. But we're on the fence. If we can fix this in the next couple days lets not, but we don't want to get blocked for more weeks on the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes PowerShell/vscode-powershell#3937. It is not a good fix, but it is viable for now. We've identified where the race condition is, and can effectively workaround it with a small sleep in the REPL. Our top priority is to fix up the REPL so this race doesn't occur in the first place, but that will require more invasive changes.