Sync ReadKeyProc thread with pipeline thread #3294
Conversation
The pipeline thread was returning before the ReadKeyProcThread had finished processing the dummy input. This was occuring somewhat frequently when ReadLine was invoked multiple times in a row creating a race condition. With these changes, the pipeline thread will wait for dummy input to be received, dequeue the key, and continue with normal cancellation logic.
There was a problem hiding this comment.
Super freaking interesting. Can we setup a call with @daxian-dbw and step through this? I think you've found the threads racing, but damn, this is interesting.
Yeah definitely ❤️ |
There was a problem hiding this comment.
@SeeminglyScience Good work narrowing down the cause!
There may still be a race condition with this change. timeout case won't affect this change. Looking.
|
Also tested and verified, and this resolves the problem. We've (well, @SeeminglyScience really) narrowed down the "extra prompt" issue as well, and while related to what we've been debugging, the cause is separate (our |
| @@ -877,7 +861,7 @@ private void DelayedOneTimeInitialize() | |||
| _readKeyWaitHandle = new AutoResetEvent(false); | |||
| _keyReadWaitHandle = new AutoResetEvent(false); | |||
| _closingWaitHandle = new ManualResetEvent(false); | |||
| _requestKeyWaitHandles = new WaitHandle[] {_keyReadWaitHandle, _closingWaitHandle, null}; | |||
There was a problem hiding this comment.
Ah ha, the questions I had earlier but hadn't written yet are now irrelevant. Yay!
|
Would it make sense to use |
Oooo another good catch, yeah I think that would work fine now since |
We can now use CancellationToken.None instead of creating a dummy cancellation token because we use `CancellationToken.IsCancellationRequested`.
|
Woo-hoo! |
|
🎉 |
PR Summary
Fix #3292
The pipeline thread was returning before the
ReadKeyProcthread had finished processing the dummy input. This was occurring somewhat frequently whenReadLinewas invoked multiple times in a row, surfacing a race condition.With these changes, the pipeline thread will wait for dummy input to be received, dequeue the key, and continue with normal cancellation logic.
PR Checklist
Microsoft Reviewers: Open in CodeFlow