Add '$' as trigger character for completion #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IntelliSense
Issue-Enhancement
andyleejordan
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
While I'm not seeing any reason not to take this change, I went ahead and tested locally and I already get completions on $. Then I saw you're using the LSP server via a client in Vim, and so I'm chalking this up to some weirdness with VS Code asking for completions anyway. Thanks for the PR!
|
In VS code quickSuggestions are enabled by default which is why $ triggers IntelliSense in VS code out of the box. If you disable them the Powershell specific triggers still start IntelliSense. I don't know if that's working as intended, but it's definitely the behavior I want because quickSuggestions makes IntelliSense a bit too aggressive IMO. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1176 so IntelliSense gets triggered automatically when writing variables.