Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger characters should contains $ too #1176

Closed
mattn opened this issue Feb 1, 2020 · 5 comments · Fixed by #1427
Closed

trigger characters should contains $ too #1176

mattn opened this issue Feb 1, 2020 · 5 comments · Fixed by #1427
Labels
Area-IntelliSense Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@mattn
Copy link

mattn commented Feb 1, 2020

I prefer to add $ into triggerChars for variables.

        public CompletionRegistrationOptions GetRegistrationOptions()
        {
            return new CompletionRegistrationOptions
            {
                DocumentSelector = new DocumentSelector(new DocumentFilter { Language = "powershell" }),
                ResolveProvider = true,
                TriggerCharacters = new[] { ".", "-", ":", "\\", "$" }
            };
        }

image

@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 1, 2020
@SydneyhSmith
Copy link
Collaborator

@mattn thanks for opening this issue, we are having trouble reproducing this...what version of editor services are you running?

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Feb 11, 2020
@SydneyhSmith SydneyhSmith added Needs-Repro-Info and removed Needs: Maintainer Attention Maintainer attention needed! Needs: Triage Maintainer attention needed! labels Feb 11, 2020
@mattn
Copy link
Author

mattn commented Feb 12, 2020

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Feb 12, 2020
@TylerLeonhardt
Copy link
Member

I wonder if VS Code is sending over the completion request even though it shouldn't... @mattn which client are you using? Looks like Vim or NeoVim?

@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Feb 12, 2020
@mattn
Copy link
Author

mattn commented Feb 12, 2020

I use vim-lsp on vim8.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Feb 12, 2020
@SydneyhSmith SydneyhSmith added Area-IntelliSense Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. and removed Needs-Repro-Info Needs: Maintainer Attention Maintainer attention needed! labels Feb 13, 2020
@SydneyhSmith
Copy link
Collaborator

@mattn yeah that looks like a great idea, feel free to open a PR

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Feb 13, 2020
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Mar 19, 2020
@ghost ghost added the Status: In PR label Mar 21, 2021
andyleejordan added a commit that referenced this issue Mar 22, 2021
Fixes #1176 so IntelliSense gets triggered automatically when writing variables.
@ghost ghost added Status: Fixed and removed Status: In PR labels Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IntelliSense Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants