Update to use OmniSharp 0.19.0 #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
338b1ed to
3194f8a
Compare
|
Working on getting this put together. FYI @rjmholt and @david-driscoll |
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
3 times, most recently
from
48d2ceb to
bedcc39
Compare
|
The PSES tests don't pass, but it builds! The extension tests pass, I think. |
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
6 times, most recently
from
8185019 to
c83f4aa
Compare
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
c83f4aa to
f5df46e
Compare
Bumps [OmniSharp.Extensions.LanguageServer](https://github.com/OmniSharp/csharp-language-server-protocol) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases) - [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml) - [Commits](OmniSharp/csharp-language-server-protocol@v0.18.3...v0.19.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [OmniSharp.Extensions.DebugAdapter.Client](https://github.com/OmniSharp/csharp-language-server-protocol) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases) - [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml) - [Commits](OmniSharp/csharp-language-server-protocol@v0.18.3...v0.19.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [OmniSharp.Extensions.LanguageClient](https://github.com/OmniSharp/csharp-language-server-protocol) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases) - [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml) - [Commits](OmniSharp/csharp-language-server-protocol@v0.18.3...v0.19.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
f5df46e to
ac9de93
Compare
…HandlerBase` Except for `TelemetryEventParams` changes, saving for later.
Which we need for `record`s, and OmniSharp forces us to use.
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
ac9de93 to
3ae17e8
Compare
andyleejordan
added
Area-Language Server
Issue-Enhancement
|
This is ready @rjmholt! |
rjmholt
approved these changes
Mar 26, 2021
andyleejordan
commented
Apr 19, 2021
| Name = "Main Thread" | ||
| }) | ||
| // TODO: This is an empty container of threads...do we need to make a thread? | ||
| Threads = new Container<System.Threading.Thread>() |
There was a problem hiding this comment.
I thought this was weird, but we already didn't really know what to do with it (see "What do I do with these?")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our base dependency, OmniSharp, from 0.18.3 to 0.19.0, which included many API changes. The approach taken to reduce code was the replacement of interface-implementations with ABC derivations, providing a few things for free for each of the derived classes, and is more inline with the expectations of the library developers. There are a couple classes that implement multiple interfaces, and have been left TODO for a switch to an ABC implementation. Furthermore, the C# language specification needed to be updated because of OmniSharp's use of new language features (namely
records), and I found that our xUnit package was misaligned.