-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force various files to be skipped when generating git archives #15078
Conversation
Meson utilizes `git archive` as the first step in producing a release tarball. Certain files don't need to be distributed in release tarballs at all -- namely, files used by git itself, or by github when processing a git repository for e.g. CI purposes. They have no use case outside of a git repo -- not even as documentation. Exclude these files from the tarball. This affects both `meson dist` and the github autogenerated tarballs on the Tags page. More work is needed to have `meson dist` reach parity with automake's `make distcheck`, but this is a start.
Pull Request Test Coverage Report for Build 12923186625Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Thanks! There is no need for 100% parity, but these files can certainly be skipped. |
LGTM. If you happen to have that autotools vs. meson tarball contents diff, I am interested :) |
meson without this PR ---> meson with this PR: meson-dist-15078.txt autotools ---> meson with this PR: autotools-to-meson-dist.txt |
oops. that question was for Otto, as I know he has the diff. But, thanks! |
I happened to have the diff too. :) |
The distfile created from the pdns root using meson is larger as the autotools distfile only includes the authoritative server related files and dnsdist and recursor each have their own distfile, created from the dnsdistdist and recursordist subdirs. #15076 is my PR to create the recursor tarball using meson. |
Meson utilizes
git archive
as the first step in producing a release tarball. Certain files don't need to be distributed in release tarballs at all -- namely, files used by git itself, or by github when processing a git repository for e.g. CI purposes. They have no use case outside of a git repo -- not even as documentation.Exclude these files from the tarball. This affects both
meson dist
and the github autogenerated tarballs on the Tags page. More work is needed to havemeson dist
reach parity with automake'smake distcheck
, but this is a start.