Rec use meson to create dist file #15076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12985846512Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Dir compare shows that the meson tarball has some extra files. The question is if we want to have these files in the meson tarball as well. They would require ragel and python as abuild dep. I'd say include in tarball for ragel and nope for python generated files. |
omoerbeek
force-pushed
the
rec-meson-dist
branch
from
07127ce to
b1d114d
Compare
gitignore files can be excluded pretty easily: #15078 |
Habbie
requested changes
Jan 23, 2025
omoerbeek
force-pushed
the
rec-meson-dist
branch
from
bd23dda to
6cb9deb
Compare
|
Current state is that this shows there are a few files missing form the autotools tarball (files not essential for building, but still...). For the rest extra files in meson tarball are 1) files needed for meson to work 2) files that wil be skipped by #15078 |
Co-authored-by: Peter van Dijk <[email protected]>
omoerbeek
force-pushed
the
rec-meson-dist
branch
from
6cb9deb to
6f2c896
Compare
|
And after a rebase to pick up #15078: All mentioned |
|
It looks quite good, nice work! |
Comment on lines
+6
to
+7
| recursor-lsan.supp export-ignore | ||
| recursor-tsan.supp export-ignore |
There was a problem hiding this comment.
Is it worth keeping these in and setting it up so that meson sanitizer builds automatically use them?
There was a problem hiding this comment.
At some point yes, but for now my goal is to produce a valid distfile. Extra features can be done later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Draft as I need to double check the differences between the the autotool generated tarball and meson generated tarball.
meson dist -C yourbuilddir --formats bztargets you the tarball.Meson dist uses a partial checkout of the tree for subprojects (as rec is), so symlinks into the parent are dangling. There is a dist script to fix those.
To bootstrap, a few symlinks are replaced in git by actual files, as the
projectclause needs them before the dist script is run.Next, after the dist dir is created, we replace the remaining symlinks into the rest of the tree by the actual files using some tar magic in the dist script.
I checked the produced tarbal can be used to build both using meson and autotools.
version.shscript from meson docs: https://mesonbuild.com/Creating-releases.html#cement-a-version-obtained-from-vcsChecklist
I have: