feat(events): show stale events in separate section #4811
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously all events would be listed in one list, irrespective of if
they have recent activity. This makes it difficult to find relevent
events if you have lots of stale events.
This change:
volume_30_days
being falsyvolume_30_days
being truthyCloses #4791
References #4502
Note that this also references #4502 as it achieves the functionality of
highlighting which events have had recent activity.
Using this issue as a test bed to get setup with the repo.
Outstanding questions
volume_30_days
to be null? I'm just going on the typescript here but is this a special case that needs to be consideredpreflight?.is_event_property_usage_enabled
Checklist