Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide events in event select box with no usage data in last 30 days #4791

Closed
timgl opened this issue Jun 17, 2021 · 7 comments · Fixed by #7422
Closed

Hide events in event select box with no usage data in last 30 days #4791

timgl opened this issue Jun 17, 2021 · 7 comments · Fixed by #7422
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@timgl
Copy link
Collaborator

timgl commented Jun 17, 2021

Is your feature request related to a problem?

We for example have 177 events. It's pretty overwhelming trying to find the event you want. Plus it's confusing when you select an event and get 0 results.
image

Describe the solution you'd like

I'd add another category (like 'Suggested for you', 'actions' and 'events' in the screenshot above) called "Dormant Events" that's automatically collapsed. Put every event in here that hasn't had any events in the last 30 days (based on volume_30_day). Make sure we only do this if preflight?.is_event_property_usage_enabled.

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

@timgl timgl added enhancement New feature or request good first issue Good for newcomers labels Jun 17, 2021
@liyiy
Copy link
Contributor

liyiy commented Jun 17, 2021

Relevant to #4502

hazzadous pushed a commit to hazzadous/posthog that referenced this issue Jun 19, 2021
Previously all events would ve listed in one list, irrespective of if
they have recent activity. This makes it difficult to find relevent
events if you have lots of stale events.

This change:

 * adds a group "Stale events" based on `volume_30_days` being falsy
 * filters the main "Events" group by `volume_30_days` being truthy

Closes PostHog#4791

References PostHog#4502

Note that this also references PostHog#4502 as it achieves the functionality of
highlighting which events have had recent activity.
@Twixes Twixes reopened this Aug 25, 2021
@Twixes Twixes removed the stale label Aug 25, 2021
@paolodamico
Copy link
Contributor

I think we could potentially show these events grayed out and/or with a "stale" label, wdyt @clarkus ?

@clarkus
Copy link
Contributor

clarkus commented Nov 29, 2021

I think we could potentially show these events grayed out and/or with a "stale" label, wdyt @clarkus ?

Sure, but I think we'll need to describe the freshness of these items a bit more. What if on hover we could show a "last seen" date or something that describes why it's dormant or stale. I don't think we should group by dormancy (at least initially) because it might make it harder to find events. I'd rather optimize for making it easy to find the event. Another option would be alternate sort attributes - for example sorting the list by freshness, alphabetically, most used, least used, etc.

@paolodamico
Copy link
Contributor

  • Agreed on showing details on the staleness as a secondary measure (e.g. on hover)
  • I don't think it makes sense to add more complexity to the box (and another decision to the user) by allowing multiple sorting, but rather prioritizing results that are used more often (as they're probably more relevant) and deprioritizing stale events.

@macobo
Copy link
Contributor

macobo commented Nov 30, 2021

Related: #7315

@mariusandra
Copy link
Collaborator

Because we have everything in tabs, and there are already too many tabs, I wouldn't add another one for "events, but not recently used" as asked the initial task. If we move away from tabs to something else, it'll become an issue again.

PR #7426 orders the list by "last 30 day volume", which I think is enough to effectively demote useless events and properties for now.

@paolodamico
Copy link
Contributor

Agreed, will only add the indicator, will not separate stale events into their own tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
8 participants