Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation to insights from dashboards #3928

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Fixes a minor bug introduced in #3866 in which navigation from dashboards to insights was broken (filters would get reset after navigating).

  • Adds a test to catch this behavior in the future.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User. Not applicable
  • Django backend tests. Not applicable
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious. Not applicable

@paolodamico paolodamico requested a review from kpthatsme April 8, 2021 21:27
@timgl timgl temporarily deployed to posthog-pr-3928 April 8, 2021 21:30 Inactive
@timgl timgl temporarily deployed to posthog-pr-3928 April 8, 2021 22:39 Inactive
@paolodamico paolodamico merged commit b1d74eb into master Apr 8, 2021
@paolodamico paolodamico deleted the fix-dashboard-insights branch April 8, 2021 22:57
fuziontech pushed a commit that referenced this pull request Apr 19, 2021
…o 3765-cohort-by-trend

* '3765-cohort-by-trend' of github.com:PostHog/posthog: (39 commits)
  'string, parsable as datetime' (#3942)
  Update plugin server to 0.16.3 (#3944)
  Resizable table columns in Sessions (#3927)
  bump cryptography==3.4.7 and add macosx_arm64 install script (#3935)
  🤖: Add jeduden as a contributor 🎉 (#3938)
  Fix feature flags default rollout (#3745)
  Less dancing in dashboards (#3824)
  Always show event stats and add warnings (#3908)
  Update plugin server to 0.16.2 (#3932)
  Minimum PostHog version in plugins (#3916)
  Renames Active users to Unique users (#3930)
  Fix action with same name (#3909)
  Fix navigation to insights from dashboards (#3928)
  User V2 Part II - Frontend changes (#3866)
  update autocapture label to be more descriptive (#3925)
  Log to sentry when migrations are out of date (#3924)
  Revert "Increase Element model varchar limits (#3912)" (#3923)
  Update plugin server to 0.16.1 (#3920)
  Are migrations safe to run on cloud?  (#3917)
  Run Automerge as posthog-bot (#3919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants