-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always show event stats and add warnings #3908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolodamico
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
a.usage_count == b.usage_count ? a.volume - b.volume : a.usage_count - b.usage_count, | ||
}, | ||
] | ||
const { user } = useValues(userLogic) | ||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a small improvement for later, I think this logic can be moved to a selector.
fuziontech
pushed a commit
that referenced
this pull request
Apr 19, 2021
…o 3765-cohort-by-trend * '3765-cohort-by-trend' of github.com:PostHog/posthog: (39 commits) 'string, parsable as datetime' (#3942) Update plugin server to 0.16.3 (#3944) Resizable table columns in Sessions (#3927) bump cryptography==3.4.7 and add macosx_arm64 install script (#3935) 🤖: Add jeduden as a contributor 🎉 (#3938) Fix feature flags default rollout (#3745) Less dancing in dashboards (#3824) Always show event stats and add warnings (#3908) Update plugin server to 0.16.2 (#3932) Minimum PostHog version in plugins (#3916) Renames Active users to Unique users (#3930) Fix action with same name (#3909) Fix navigation to insights from dashboards (#3928) User V2 Part II - Frontend changes (#3866) update autocapture label to be more descriptive (#3925) Log to sentry when migrations are out of date (#3924) Revert "Increase Element model varchar limits (#3912)" (#3923) Update plugin server to 0.16.1 (#3920) Are migrations safe to run on cloud? (#3917) Run Automerge as posthog-bot (#3919) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ASYNC_EVENT_PROPERTY_USAGE
isn't set (so we won't have any stats to show)Checklist