fix: surveys validate conditions

posthog/api/survey.py

@@ -211,15 +211,23 @@ def validate_conditions(self, value):
         if value is None:
             return value
 
-        actions = value.get("actions")
+        if not isinstance(value, dict):
+            raise serializers.ValidationError("Conditions must be an object")
+
+        actions = value.get("actions", None)
+
         if actions is None:
             return value
 
-        values = actions.get("values")
+        values = actions.get("values", None)
         if values is None or len(values) == 0:
             return value
 
-        action_ids = (value.get("id") for value in values)
+        action_ids = [value.get("id") for value in values if isinstance(value, dict) and "id" in value]
+
+        if len(action_ids) == 0:
+            return value
+
         project_actions = Action.objects.filter(team__project_id=self.context["project_id"], id__in=action_ids)
 
         for project_action in project_actions:
@@ -755,7 +763,7 @@ def summarize_responses(self, request: request.Request, **kwargs):
 
         survey = self.get_object()
 
-        cache_key = f'summarize_survey_responses_{self.team.pk}_{self.kwargs["pk"]}'
+        cache_key = f"summarize_survey_responses_{self.team.pk}_{self.kwargs['pk']}"
         # Check if the response is cached
         cached_response = cache.get(cache_key)
         if cached_response is not None: