fix: surveys validate conditions

[marandaneto]

Problem

AttributeError
'str' object has no attribute 'get'

https://posthog.sentry.io/issues/6294642235/?alert_rule_id=15777369&alert_type=issue&notification_uuid=1392b11e-fcc6-4661-9fb7-ca780439ee5e&project=1899813

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

[marandaneto]

commit linter did that so I guess its safe

[greptile-apps]

PR Summary

This PR adds validation for survey conditions to prevent runtime errors, specifically addressing a Sentry-reported AttributeError where string values were being incorrectly passed instead of dictionaries.

• Added validation in posthog/api/survey.py to ensure survey conditions are provided as dictionary objects
• Fixed potential AttributeError when string values were passed instead of dictionaries for survey conditions
• Updated survey response summarization cache key formatting for better consistency

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[ioannisj]

I think we probably need a similar check here?

posthog/posthog/api/survey.py

Line 561 in 75a2b82

actions = conditions.get("actions")

[marandaneto]

I think we probably need a similar check here?

posthog/posthog/api/survey.py

Line 561 in 75a2b82

actions = conditions.get("actions")

I don't think so since those are called manually.
validate_conditions is called by django, so If I guess it right, the validate_conditions already has been executed and thrown if something is off, and the calls to _associate_actions should be ok by this time.

[marandaneto]

@pauldambra adding you master of djangos so you double check my comment here.

[pauldambra]

@marandaneto @ioannisj looks like the conditions definition is conditions = models.JSONField(blank=True, null=True) so None is a valid value for conditions, no?

and in the validator

    def validate_conditions(self, value):
        if value is None:
            return value

so i think can definitely be None

[pauldambra]

so this makes the return type dict | None

[pauldambra]

surgical 👨‍⚕️

[ioannisj]

Based on the discussion I think this should be 👍