fix(flags): Update instructions for remote config settings #28705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to retrieve remote config settings is the same whether or not the paylod is encrypted. This commit updates the instructions to reflect that.
|
Pushed a fix for Ruby.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the feature flag instructions to ensure consistent handling of remote configuration settings across SDKs, regardless of payload encryption status.
- Renamed
ENCRYPTED_PAYLOAD_LIBRARIEStoREMOTE_CONFIGURATION_LIBRARIESin/frontend/src/scenes/feature-flags/FeatureFlagCodeOptions.tsxfor better clarity - Added new
remoteConfigurationandencryptedPayloadprops to snippets in/frontend/src/scenes/feature-flags/FeatureFlagSnippets.tsx - Added clear messaging about payload decryption handling in code examples
- Updated library selection logic in
/frontend/src/scenes/feature-flags/FeatureFlagInstructions.tsxto be based on remote configuration status - Standardized remote configuration API endpoint handling across server-side SDKs
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
havenbarnes
approved these changes
Feb 14, 2025
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The instructions for unencrypted remote config settings is incorrect.
The code to retrieve remote config settings is the same whether or not the payload is encrypted.
This commit updates the instructions to reflect that.
Changes
Unencrypted instructions:
Encrypted instructions:
The code is the same, but there's an extra line explaining how the decryption works.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manually