feat(flags): Add C# language examples for feature flags #28702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this doesn't include the recently shipped remote config setting code. I'll get to that soon. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added C# language support for feature flags in PostHog, including code snippets, documentation links, and UI elements for the .NET SDK.
- Added
CSharpSnippetcomponent in/frontend/src/scenes/feature-flags/FeatureFlagSnippets.tsxwith async/await patterns and C# naming conventions - Added
DOTNETSDK key toSDKKeyenum in/frontend/src/types.tsand included in local evaluation/payload libraries lists - Added
IconCSharpcomponent in/frontend/src/lib/lemon-ui/icons/icons.tsxfor C# language representation - Added C# language support to
CodeSnippetcomponent with Prism syntax highlighting integration - Added C# implementation examples with proper documentation links in
FeatureFlagCodeOptions.tsx
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +5 B (0%) Total Size: 1.21 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
I need #28705 to land before I can merge this. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
HamedMP
pushed a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds C# as a language in the "How to implement" section when looking at the details for a feature flag.
Changes
Some examples.
Does this work well for both Cloud and self-hosted?
Yes.
How did you test this code?
Manually tested.