Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: device type display on survey, and spacing between filters #28581

Merged
merged 2 commits into from
Feb 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
32 changes: 17 additions & 15 deletions frontend/src/scenes/surveys/Survey.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,17 +138,17 @@ export function SurveyDisplaySummary({
</div>
)}
{survey.conditions?.deviceTypes && (
<div className="flex flex-col font-medium gap-1">
<div className="flex-row">
<span>
Device Types{' '}
{SurveyMatchTypeLabels[
survey.conditions?.deviceTypesMatchType || SurveyMatchType.Contains
].slice(2)}
:
</span>{' '}
<LemonTag>{survey.conditions.deviceTypes?.join(', ')}</LemonTag>
</div>
<div className="flex font-medium gap-1 items-center">
<span>
Device Types{' '}
{SurveyMatchTypeLabels[
survey.conditions?.deviceTypesMatchType || SurveyMatchType.Contains
].slice(2)}
:
</span>{' '}
{survey.conditions.deviceTypes.map((type) => (
<LemonTag key={type}>{type}</LemonTag>
))}
</div>
)}
{survey.conditions?.selector && (
Expand Down Expand Up @@ -182,10 +182,12 @@ export function SurveyDisplaySummary({
</div>
)}
{targetingFlagFilters && (
<BindLogic logic={featureFlagLogic} props={{ id: survey.targeting_flag?.id || 'new' }}>
<span className="font-medium">User properties:</span>{' '}
<FeatureFlagReleaseConditions readOnly excludeTitle filters={targetingFlagFilters} />
</BindLogic>
<div>
<BindLogic logic={featureFlagLogic} props={{ id: survey.targeting_flag?.id || 'new' }}>
<span className="font-medium">User properties:</span>{' '}
<FeatureFlagReleaseConditions readOnly excludeTitle filters={targetingFlagFilters} />
</BindLogic>
</div>
)}
</div>
)
Expand Down
Loading