fix: device type display on survey, and spacing between filters #28581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves the visual presentation of device types and filter spacing in the survey display summary view.
- Modified
frontend/src/scenes/surveys/Survey.tsxto render individualLemonTagcomponents for each device type instead of combining them into a single tag - Added wrapper div around targeting flag filters to fix inconsistent spacing between "User properties" section and filter components
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated12 snapshot changes in total. 0 added, 12 modified, 0 deleted:
Triggered by this commit. |
marandaneto
deleted the
fix/spacing-and-device-type-display-on-survey
branch
zlwaterfield
pushed a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Makes it so Device Types are shown similarly to how they're shown on the Survey form as well.
Fixes extra spacing between "User properties" and the actual component.
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
UI changes only. Checked if all tests are still passing, and manually tested survey form to see if it's still working as expected