Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Fixes #43 #44

Merged
merged 1 commit into from
Jun 30, 2015
Merged

Fixes #43 #44

merged 1 commit into from
Jun 30, 2015

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Jun 30, 2015

@addyosmani
Copy link
Contributor

lgtm (however I can't recall why childNodes was used instead of children). Deferring to Jeff and Mat

@wibblymat
Copy link
Contributor

I believe that I wrote that line when translating from 0.5 to 0.8. No special reason for one over the other - I didn't realise that there was an alternative, or really what childNodes actually did.

@jeffposnick
Copy link
Contributor

I think I wrote that bit, but I basically have the same explanation as @wibblymat—it may have been because I saw Polymer.dom(parent).childNodes listed in the docs and assumed that was the right thing to use.

👍 if this fixes the issue you were seeing.

I'll cut a new release after addressing the docs issues in #45

jeffposnick added a commit that referenced this pull request Jun 30, 2015
@jeffposnick jeffposnick merged commit faf7d88 into master Jun 30, 2015
@jeffposnick jeffposnick deleted the ebidel-patch-1 branch June 30, 2015 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants