Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Usage of .children instead of .childNodes #43

Closed
ebidel opened this issue Jun 29, 2015 · 0 comments
Closed

Usage of .children instead of .childNodes #43

ebidel opened this issue Jun 29, 2015 · 0 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Jun 29, 2015

https://github.com/PolymerElements/platinum-sw/blob/master/platinum-sw-register.html#L225

uses childNodes, which enumerates nodes that are not valid sw element child: textnodes, comments, etc.

Is there a reason it's not using .children?
@ebidel ebidel changed the title Usage of children instead of childNodes Usage of .children instead of .childNodes Jun 29, 2015
@ebidel ebidel closed this as completed in b2cce69 Jun 30, 2015
jeffposnick added a commit that referenced this issue Jun 30, 2015
@jeffposnick
Merge pull request #44 from PolymerElements/ebidel-patch-1
faf7d88 
Fixes #43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebidel