Upgrade to polkadot-stable2412-1
#448
Open
+5,238
−3,552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (02/05/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
dastansam
commented
Feb 6, 2025
| type DefaultVote = pallet_collective::MoreThanMajorityThenPrimeDefaultVote; | ||
| type DisapproveOrigin = EitherOfDiverse< |
There was a problem hiding this comment.
copied from ApproveOrigin above
| @@ -239,7 +239,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| impl_version: 0, | |||
| apis: RUNTIME_API_VERSIONS, | |||
| transaction_version: 1, | |||
| state_version: 1, | |||
| system_version: 1, | |||
There was a problem hiding this comment.
should probably be bumped to system_version: 2 (?)
dastansam
commented
Feb 6, 2025
|
|
||
| parameter_types! { | ||
| /// The basic deposit to create an identity. | ||
| pub const BasicDeposit: Balance = 20 * PLMC; | ||
| /// Deposit for each additional field. | ||
| pub const ByteDeposit: Balance = deposit(0, 1); | ||
| /// Username deposit for identity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Work in progress upgrade to new stable version.
closes #446
Tasks
stable2409and1.14.0).stable2412.Additional Context
Treasury::propose_spend(...)integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced byTreasury::sped_local(...). We can ignore these tests for now and re-add them in a later PR.Why?
Release analysis posts here.
Some notable PRs:
SignedExtrawith newTransactionExtension. This requires us to reimplement the customCheckNonceas a follow up PR - FRAME: ReintroduceTransactionExtensionas a replacement forSignedExtensionparitytech/polkadot-sdk#3685latest, sov4xcm types are replaced withv5- XCM v5 paritytech/polkadot-sdk#4826 -xcm-fee-payment-runtime-apimodule into the newxcm-runtime-apis- [xcm] runtime api for LocationToAccount conversions paritytech/polkadot-sdk#4857How?
Testing?
cargo t -p pallet-funding)cargo t -p integration-tests)Screenshots (optional)
Syncing with mainnet `polimec`
`try-runtime` fails for `pallet-identity`
Anything Else?
workspacedependenciesFollow ups
Fix integration tests errorsRemoveSignedExtensiondeprecation warnings, by replacing it withTxExtensionormlcrates once new release is pushedpallet-migrationsfor multi block migrations support.pallet_identity::V1ToV2migrations is a lazy migration which needspallet-migrations(see 2 in screenshots)