Upgrade Polkadot SDK from 1.13.0 to stable2412

[lrazovic]

This issue tracks the upgrade of the Polkadot SDK dependencies from version 1.13.0 (currently in use) to stable2412.

Tasks

• Review release notes for stable2412 for breaking changes. Also check the release notes of the versions before (with a focus on stable2409 and 1.14.0).
• Update Polkadot SDK dependencies to stable2412.
• Update ORML dependencies to the according version.
• Test node and runtime compatibility (e.g., compile-time errors, runtime APIs, storage migrations).
• Audit custom pallets for deprecated or changed SDK interfaces.
• Update benchmarks (if applicable) for weight calculations.

Testing

• Pallet Unit Testing (e.g. cargo t -p pallet-funding)
• Integration Tests (e.g. cargo t -p integration-tests)
• Try Runtime CLI, to test if we have to run any migration in this upgrade.

Additional Context

• You can use PSVM to lift all the Polkadot SDK dependencies in one command.
  • E.g.: psvm -v "polkadot-stable2412"
  • Please align also the "External" crates to the version used in the Polkadot SDK. (Especially jsonrpsee)
• The Treasury::propose_spend(...) integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced by Treasury::sped_local(...). We can ignore these tests for now and re-add them in a later PR.

Branch: Work can be done in a feature branch (e.g., upgrade/sdk-stable2412).

[dastansam]

hey @lrazovic

just started working on this, but there is a known issue with polkadot-stable2412. polkadot-stable2412-1 or v1.14.0 don't seem to have that issue and it actually upgrades deps. But that is more/less release notes to cover and not sure if you would want that :)

[lrazovic]

The stable2412-1 should also be ok! The main blocker are usually the external dependencies (OMRL in our case), but the latest version is compatible with stable2412 and should also be compatible with stable2412-1

[dastansam]

The stable2412-1 should also be ok! The main blocker are usually the external dependencies (OMRL in our case), but the latest version is compatible with stable2412 and should also be compatible with stable2412-1

orml main branch is compatible with stable2412 indeed, but new release is blocked. Seems like it should be released soon as the scale-codec blocking issue is actively being worked on.

I still went ahead and fixed the compile errors besides the errors caused by the version mismatch. but until orml new release, we can't really test it

[dastansam]

The stable2412-1 should also be ok! The main blocker are usually the external dependencies (OMRL in our case), but the latest version is compatible with stable2412 and should also be compatible with stable2412-1

orml main branch is compatible with stable2412 indeed, but new release is blocked. Seems like it should be released soon as the scale-codec blocking issue is actively being worked on.

I still went ahead and fixed the compile errors besides the errors caused by the version mismatch. but until orml new release, we can't really test it

actually, found a temporary fix. forked the orml and using the deps with git repo as a source