Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/master and subscribers #338

Merged
merged 42 commits into from
Jun 21, 2024
Merged

Conversation

PilzES
Copy link
Contributor

@PilzES PilzES commented Jan 5, 2024

Description

These changes allow the user to to use the ROS package "psen_scan_v2" with: One PSENscan (Master or Light), and up to four PSENscan's (Master + Subscriber0 + Subscriber1 + Subscriber2).

** Implemented:**

  • Run one scanner (Master, Light) or multiple scanners (Master + Subscriber0 + Subscriber1 + Subscriber2), and exchange the information provided by the scanners (scan data, scan counter, scanner ID, zone set, ....) with ROS.
  • Exchange the information provided by the config.xml file with Master and Subscribers configuration with the active_zoneset_node and visualize the markers configured in the multiple Scanners.

PR Checklist

Things to add, update or check by the maintainers before this PR can be merged.

  • Public api function documentation
  • Architecture documentation reflects actual code structure
  • Tutorials
  • Overview on ROS wiki
  • Package Readme (example pilz_robots)
  • Good commit messages (some tips)
  • CHANGELOG.rst updated
  • Copyright headers
  • Examples

Review Checklist

  • Soft- and hardware architecture (diagrams and description)
  • Test review (test plan and individual test cases)
  • Documentation describes purpose of file(s) and responsibilities
  • Code (coding rules, style guide)

Release planning (please answer)

  • When is the new feature released?
  • Which dependent packages do have to be released simultaneously?

Hardware tests

Unstrike the text below to enable automatic hardware tests if available. Otherwise use this as a request for the reviewer.

  • Perform hardware tests

Copy link
Contributor

@martiniil martiniil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I am not sure if the existing tests do cover the new feature sufficiently. Did you consider? I am out of time now and will have another glance tomorrow.

include/psen_scan_v2/ros_scanner_node.h Outdated Show resolved Hide resolved
include/psen_scan_v2/ros_scanner_node.h Outdated Show resolved Hide resolved
@Alex-Howroyd Alex-Howroyd merged commit 079f5c7 into PilzDE:main Jun 21, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants