-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/master and subscribers #338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass slave_id to laserscan message and publish slave data with seperate frame_id
… two, three, four
martiniil
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I am not sure if the existing tests do cover the new feature sufficiently. Did you consider? I am out of time now and will have another glance tomorrow.
martiniil
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes allow the user to to use the ROS package "psen_scan_v2" with: One PSENscan (Master or Light), and up to four PSENscan's (Master + Subscriber0 + Subscriber1 + Subscriber2).
** Implemented:**
PR Checklist
Things to add, update or check by the maintainers before this PR can be merged.
Review Checklist
Release planning (please answer)
Hardware tests
Unstrike the text below to enable automatic hardware tests if available. Otherwise use this as a request for the reviewer.
Perform hardware tests