Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PSC causing lag via selective update broadcasting #28

Merged
merged 4 commits into from
Jul 17, 2020
Merged

Fix PSC causing lag via selective update broadcasting #28

merged 4 commits into from
Jul 17, 2020

Conversation

Bankst
Copy link
Member

@Bankst Bankst commented Jul 12, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jul 12, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@53783d8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage          ?   54.57%           
  Complexity        ?      498           
=========================================
  Files             ?      138           
  Lines             ?     3927           
  Branches          ?      357           
=========================================
  Hits              ?     2143           
  Misses            ?     1663           
  Partials          ?      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53783d8...a7e6dd9. Read the comment docs.

@Bankst
Copy link
Member Author

Bankst commented Jul 12, 2020

Waiting on #22 to get merged so the frontend side can be added

@Bankst
Copy link
Member Author

Bankst commented Jul 13, 2020

Replace full-settings send in VisionModule with selective send

@Bankst Bankst changed the title [WIP] Fix PSC causing lag via selective update broadcasting Fix PSC causing lag via selective update broadcasting Jul 17, 2020
@Bankst Bankst marked this pull request as ready for review July 17, 2020 03:24
@Bankst Bankst requested a review from a team as a code owner July 17, 2020 03:24
mcm001
mcm001 requested changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change app.vue's hasOwnProperty thing to be

this.$store.commit('mutatePipeline', {[key]: value});

@mcm001 mcm001 merged commit bac09bf into PhotonVision:master Jul 17, 2020
@Bankst Bankst deleted the selective-send branch July 18, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bankst @mcm001